Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1086213004: Fix compilation with enable_supervised_users == 0. (Closed)

Created:
5 years, 8 months ago by kotenkov
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, merkulova, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix compilation with enable_supervised_users == 0. BUG= Committed: https://crrev.com/86954551255790edf296da118a2cd6927e69ac24 Cr-Commit-Position: refs/heads/master@{#325456}

Patch Set 1 #

Patch Set 2 : Fix browser_prefs.cc compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kotenkov
Supervised users are enabled by default, but most code concerning them is under ifdefs, so ...
5 years, 8 months ago (2015-04-16 08:40:36 UTC) #2
Nico
lgtm (+ related folks as fyi)
5 years, 8 months ago (2015-04-16 15:18:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086213004/20001
5 years, 8 months ago (2015-04-16 15:18:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 16:40:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:41:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86954551255790edf296da118a2cd6927e69ac24
Cr-Commit-Position: refs/heads/master@{#325456}

Powered by Google App Engine
This is Rietveld 408576698