Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1086193002: Remove some files from the Windows non-deterministic whitelist. (Closed)

Created:
5 years, 8 months ago by Sébastien Marchand
Modified:
5 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove some files from the Windows non-deterministic whitelist. BUG=429358, 383364 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294827

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py View 2 chunks +0 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
PTAL.
5 years, 8 months ago (2015-04-15 20:41:17 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/1086193002/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py File scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py (left): https://codereview.chromium.org/1086193002/diff/1/scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py#oldcode33 scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py:33: # http://crbug.com/383364 Please refer this bug too in ...
5 years, 8 months ago (2015-04-15 20:44:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086193002/1
5 years, 8 months ago (2015-04-15 20:45:53 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:48:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294827

Powered by Google App Engine
This is Rietveld 408576698