Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1086163002: Fix MB configurations for Mac and Win GN bots. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MB configurations for Mac and Win GN bots. The windows bots were incorrectly doing 64-bit builds, and the debug bots (both mac and win) were incorrectly doing shared builds. TBR=phajdan.jr@chromium.org BUG=454413 CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/31a66f3e705d20a39033a7b7d7f09a60517e6b9d Cr-Commit-Position: refs/heads/master@{#325297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
5 years, 8 months ago (2015-04-15 20:11:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086163002/1
5 years, 8 months ago (2015-04-15 20:15:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 20:51:06 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:52:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31a66f3e705d20a39033a7b7d7f09a60517e6b9d
Cr-Commit-Position: refs/heads/master@{#325297}

Powered by Google App Engine
This is Rietveld 408576698