Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 1086143003: Update more directories under src/ to follow C++11 style rule for {virtual,override}. (Closed)

Created:
5 years, 8 months ago by tfarina
Modified:
5 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update more directories under src/ to follow C++11 style rule for {virtual,override}. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/7831a4bbb46a919316efc7c70808dcaaf8ee629a

Patch Set 1 #

Total comments: 3

Patch Set 2 : no copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M src/codec/SkCodec_libbmp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/image/SkSurface_Gpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/opts/SkXfermode_opts_SSE2.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/opts/SkXfermode_opts_arm_neon.h View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086143003/1
5 years, 8 months ago (2015-04-27 00:28:48 UTC) #2
tfarina
https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h File src/opts/SkXfermode_opts_arm_neon.h (right): https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h#newcode2 src/opts/SkXfermode_opts_arm_neon.h:2: * Copyright 2015 Google Inc. This was necessary because ...
5 years, 8 months ago (2015-04-27 00:30:03 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-27 00:32:04 UTC) #5
mtklein
https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h File src/opts/SkXfermode_opts_arm_neon.h (right): https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h#newcode2 src/opts/SkXfermode_opts_arm_neon.h:2: * Copyright 2015 Google Inc. On 2015/04/27 00:30:03, tfarina ...
5 years, 8 months ago (2015-04-27 13:29:40 UTC) #6
tfarina
https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h File src/opts/SkXfermode_opts_arm_neon.h (right): https://codereview.chromium.org/1086143003/diff/1/src/opts/SkXfermode_opts_arm_neon.h#newcode2 src/opts/SkXfermode_opts_arm_neon.h:2: * Copyright 2015 Google Inc. On 2015/04/27 13:29:40, mtklein ...
5 years, 8 months ago (2015-04-27 14:04:53 UTC) #7
mtklein
lgtm
5 years, 8 months ago (2015-04-27 14:46:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086143003/20001
5 years, 8 months ago (2015-04-27 14:46:53 UTC) #10
commit-bot: I haz the power
Presubmit check for 1086143003-20001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-27 14:46:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086143003/20001
5 years, 8 months ago (2015-04-27 14:47:44 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:53:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7831a4bbb46a919316efc7c70808dcaaf8ee629a

Powered by Google App Engine
This is Rietveld 408576698