Issue 108613005: Ensure we call onUnlock only if onLock succeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108613005: Ensure we call onUnlock only if onLock succeeded (Closed)

Created:
7 years ago by reed1

Modified:
7 years ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert "Revert of https://codereview.chromium.org/112783004/" This reverts commit 3293fe57a7507541e9040eab880dcd82c43881f4. Conflicts: src/core/SkScaledImageCache.cpp BUG= Committed: https://code.google.com/p/skia/source/detail?r=12663

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -23 lines)			Patch
M	include/core/SkPixelRef.h	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View		2 chunks	+12 lines, -3 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View		4 chunks	+2 lines, -6 lines	0 comments	Download
M	src/images/SkImageRef_ashmem.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

Committed patchset #2 manually as r12663 (presubmit successful).