Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1086083005: DevTools: Add banks to JS sampling code map. (Closed)

Created:
5 years ago by alph
Modified:
4 years, 10 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Add banks to JS sampling code map. The double type used to store addresses can hold exact numbers for up to 2^53 (as this is the size of mantissa). However raw frame addresses stored in V8 samples can be up to 64-bit long. The patch introduce banks to CodeMap. Raw address then split into bank (upper 12 bits) and an address within the bank (lower 52 bits). This way 52-bit addresses can safely be stored in JS double type. BUG=406277 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197668

Patch Set 1 #

Patch Set 2 : rebaseline #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -23 lines) Patch
A LayoutTests/inspector/tracing/timeline-sampling-codemap.html View 1 chunk +64 lines, -0 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-sampling-codemap-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 4 chunks +82 lines, -23 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
alph
5 years ago (2015-04-21 18:24:23 UTC) #2
yurys
Can we reuse codemap.js [1] (along with the splay tree implementation) from v8? [1] https://code.google.com/p/chromium/codesearch#chromium/src/v8/tools/codemap.js&q=codemap.js&sq=package:chromium&type=cs
5 years ago (2015-04-22 12:44:40 UTC) #3
alph
On 2015/04/22 12:44:40, yurys wrote: > Can we reuse codemap.js [1] (along with the splay ...
4 years, 10 months ago (2015-06-22 15:52:51 UTC) #4
yurys
lgtm https://codereview.chromium.org/1086083005/diff/20001/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (right): https://codereview.chromium.org/1086083005/diff/20001/Source/devtools/front_end/timeline/TimelineJSProfile.js#newcode290 Source/devtools/front_end/timeline/TimelineJSProfile.js:290: var /** @const */ bankSizeHexDigits = 13; Please ...
4 years, 10 months ago (2015-06-22 16:33:00 UTC) #5
alph
https://codereview.chromium.org/1086083005/diff/20001/Source/devtools/front_end/timeline/TimelineJSProfile.js File Source/devtools/front_end/timeline/TimelineJSProfile.js (right): https://codereview.chromium.org/1086083005/diff/20001/Source/devtools/front_end/timeline/TimelineJSProfile.js#newcode290 Source/devtools/front_end/timeline/TimelineJSProfile.js:290: var /** @const */ bankSizeHexDigits = 13; On 2015/06/22 ...
4 years, 10 months ago (2015-06-23 16:06:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086083005/20001
4 years, 10 months ago (2015-06-23 16:07:09 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 18:55:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197668

Powered by Google App Engine
This is Rietveld 408576698