Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ported to all architectures. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1254 matching lines...) Expand 10 before | Expand all | Expand 10 after
1265 // For proxies, no filtering is done. 1265 // For proxies, no filtering is done.
1266 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet. 1266 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1267 STATIC_ASSERT(kSmiTag == 0); 1267 STATIC_ASSERT(kSmiTag == 0);
1268 __ Cbz(x2, &update_each); 1268 __ Cbz(x2, &update_each);
1269 1269
1270 // Convert the entry to a string or (smi) 0 if it isn't a property 1270 // Convert the entry to a string or (smi) 0 if it isn't a property
1271 // any more. If the property has been removed while iterating, we 1271 // any more. If the property has been removed while iterating, we
1272 // just skip it. 1272 // just skip it.
1273 __ Push(x1, x3); 1273 __ Push(x1, x3);
1274 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION); 1274 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);
1275 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1275 __ Mov(x3, x0); 1276 __ Mov(x3, x0);
1276 __ Cbz(x0, loop_statement.continue_label()); 1277 __ Cbz(x0, loop_statement.continue_label());
1277 1278
1278 // Update the 'each' property or variable from the possibly filtered 1279 // Update the 'each' property or variable from the possibly filtered
1279 // entry in register x3. 1280 // entry in register x3.
1280 __ Bind(&update_each); 1281 __ Bind(&update_each);
1281 __ Mov(result_register(), x3); 1282 __ Mov(result_register(), x3);
1282 // Perform the assignment as if via '='. 1283 // Perform the assignment as if via '='.
1283 { EffectContext context(this); 1284 { EffectContext context(this);
1284 EmitAssignment(stmt->each()); 1285 EmitAssignment(stmt->each());
(...skipping 4223 matching lines...) Expand 10 before | Expand all | Expand 10 after
5508 } 5509 }
5509 } 5510 }
5510 5511
5511 return INTERRUPT; 5512 return INTERRUPT;
5512 } 5513 }
5513 5514
5514 5515
5515 } } // namespace v8::internal 5516 } } // namespace v8::internal
5516 5517
5517 #endif // V8_TARGET_ARCH_ARM64 5518 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698