Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1086083002: [turbofan] Fix ForInStatement that deopts during filter. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Ported to all architectures. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet. 1278 // TODO(rossberg): What if only a prototype is a proxy? Not specified yet.
1279 __ cmp(r2, Operand(Smi::FromInt(0))); 1279 __ cmp(r2, Operand(Smi::FromInt(0)));
1280 __ b(eq, &update_each); 1280 __ b(eq, &update_each);
1281 1281
1282 // Convert the entry to a string or (smi) 0 if it isn't a property 1282 // Convert the entry to a string or (smi) 0 if it isn't a property
1283 // any more. If the property has been removed while iterating, we 1283 // any more. If the property has been removed while iterating, we
1284 // just skip it. 1284 // just skip it.
1285 __ push(r1); // Enumerable. 1285 __ push(r1); // Enumerable.
1286 __ push(r3); // Current entry. 1286 __ push(r3); // Current entry.
1287 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION); 1287 __ InvokeBuiltin(Builtins::FILTER_KEY, CALL_FUNCTION);
1288 PrepareForBailoutForId(stmt->FilterId(), TOS_REG);
1288 __ mov(r3, Operand(r0), SetCC); 1289 __ mov(r3, Operand(r0), SetCC);
1289 __ b(eq, loop_statement.continue_label()); 1290 __ b(eq, loop_statement.continue_label());
1290 1291
1291 // Update the 'each' property or variable from the possibly filtered 1292 // Update the 'each' property or variable from the possibly filtered
1292 // entry in register r3. 1293 // entry in register r3.
1293 __ bind(&update_each); 1294 __ bind(&update_each);
1294 __ mov(result_register(), r3); 1295 __ mov(result_register(), r3);
1295 // Perform the assignment as if via '='. 1296 // Perform the assignment as if via '='.
1296 { EffectContext context(this); 1297 { EffectContext context(this);
1297 EmitAssignment(stmt->each()); 1298 EmitAssignment(stmt->each());
(...skipping 4235 matching lines...) Expand 10 before | Expand all | Expand 10 after
5533 5534
5534 DCHECK(interrupt_address == 5535 DCHECK(interrupt_address ==
5535 isolate->builtins()->OsrAfterStackCheck()->entry()); 5536 isolate->builtins()->OsrAfterStackCheck()->entry());
5536 return OSR_AFTER_STACK_CHECK; 5537 return OSR_AFTER_STACK_CHECK;
5537 } 5538 }
5538 5539
5539 5540
5540 } } // namespace v8::internal 5541 } } // namespace v8::internal
5541 5542
5542 #endif // V8_TARGET_ARCH_ARM 5543 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698