Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4597)

Unified Diff: chrome/browser/signin/signin_promo.cc

Issue 1086073006: Fix DCHECK when upgrading from an old profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_promo.cc
diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc
index a3404a91322bbbaf40d6d4c83b5c345915c9cf65..05fb0b04487b6b655e154a73f74d0cc9967a203a 100644
--- a/chrome/browser/signin/signin_promo.cc
+++ b/chrome/browser/signin/signin_promo.cc
@@ -182,9 +182,18 @@ GURL GetPromoURL(signin_metrics::Source source,
}
GURL GetReauthURL(Profile* profile, const std::string& account_id) {
+ AccountTrackerService* account_tracker =
+ AccountTrackerServiceFactory::GetForProfile(profile);
AccountTrackerService::AccountInfo info =
- AccountTrackerServiceFactory::GetForProfile(profile)->
- GetAccountInfo(account_id);
+ account_tracker->GetAccountInfo(account_id);
+
+ // Until we switch to gaia id as the account id, we'll assume we can use the
+ // account_id as an email. This DCHECK makes sure this code is not forgotten
+ // during the migration.
+ DCHECK(!info.email.empty() ||
+ (account_tracker->GetMigrationState() ==
+ AccountTrackerService::MIGRATION_NOT_STARTED));
+ std::string email = info.email.empty() ? account_id : info.email;
signin_metrics::Source source = switches::IsNewAvatarMenu() ?
signin_metrics::SOURCE_REAUTH : signin_metrics::SOURCE_SETTINGS;
@@ -192,7 +201,7 @@ GURL GetReauthURL(Profile* profile, const std::string& account_id) {
GURL url = signin::GetPromoURL(
source, true /* auto_close */,
switches::IsNewAvatarMenu() /* is_constrained */);
- url = net::AppendQueryParameter(url, "email", info.email);
+ url = net::AppendQueryParameter(url, "email", email);
url = net::AppendQueryParameter(url, "validateEmail", "1");
return net::AppendQueryParameter(url, "readOnlyEmail", "1");
}
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service.cc » ('j') | components/signin/core/browser/signin_manager_base.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698