Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1086073004: Web MIDI: namespace change from media to media::midi (Closed)

Created:
5 years, 8 months ago by Takashi Toyoshima
Modified:
5 years, 7 months ago
CC:
android-webview-reviews_chromium.org, avayvod+watch_chromium.org, bruening+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, glider+watch_chromium.org, gunsch+watch_chromium.org, jam, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, lcwu+watch_chromium.org, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org, wjia+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@null
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: namespace change from media to media::midi This is a mechanical change to use namespace midi inside namespace media. BUG=475869 TEST=git cl try TBR=palmer@chromium.org Committed: https://crrev.com/78b9d632216a85390766a1fa04f321954e4a1da2 Cr-Commit-Position: refs/heads/master@{#328930}

Patch Set 1 : for git cl try (containing a dependent CL) #

Patch Set 2 : test build fix #

Patch Set 3 : split the parent CL out #

Patch Set 4 : rebase #

Patch Set 5 : fix rebase errors #

Patch Set 6 : android build fix #

Total comments: 2

Patch Set 7 : git cl format #

Patch Set 8 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -100 lines) Patch
M content/browser/browser_main_loop.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/midi_host.h View 1 2 3 4 5 6 2 chunks +14 lines, -11 lines 0 comments Download
M content/browser/media/midi_host.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M content/browser/media/midi_host_unittest.cc View 1 2 3 4 5 6 3 chunks +7 lines, -6 lines 0 comments Download
M content/common/media/midi_messages.h View 3 chunks +10 lines, -9 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 4 chunks +16 lines, -16 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 1 2 3 4 5 6 13 chunks +22 lines, -21 lines 0 comments Download
M content/renderer/media/midi_message_filter_unittest.cc View 1 2 3 4 5 6 1 chunk +6 lines, -5 lines 0 comments Download
M media/midi/midi_manager.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_alsa_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_android.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_mac.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_mac.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_mac_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_win.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_manager_win.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_queue.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_queue.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_queue_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_util.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_message_util_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_port_info.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_port_info.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_result.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_scheduler.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/midi_scheduler.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M media/midi/usb_midi_descriptor_parser.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_descriptor_parser_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_device.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_device_android.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_device_android.cc View 1 2 3 4 5 6 6 chunks +11 lines, -9 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M media/midi/usb_midi_input_stream.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_input_stream.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_input_stream_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_jack.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_output_stream.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_output_stream.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M media/midi/usb_midi_output_stream_unittest.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Takashi Toyoshima
jochen: for content/browser/browser_main_loop.{cc|h} palmer: for content/common/media/midi_messages.h yhirano: other midi related files Can you take alook?
5 years, 7 months ago (2015-05-01 04:43:02 UTC) #6
yhirano
lgtm for media/midi. https://codereview.chromium.org/1086073004/diff/120001/media/midi/usb_midi_device_android.cc File media/midi/usb_midi_device_android.cc (right): https://codereview.chromium.org/1086073004/diff/120001/media/midi/usb_midi_device_android.cc#newcode25 media/midi/usb_midi_device_android.cc:25: reinterpret_cast<jlong>(this)); indent https://codereview.chromium.org/1086073004/diff/120001/media/midi/usb_midi_device_android.cc#newcode60 media/midi/usb_midi_device_android.cc:60: data_to_pass.obj()); indent
5 years, 7 months ago (2015-05-01 07:41:43 UTC) #7
Takashi Toyoshima
Done by git cl format. Thanks.
5 years, 7 months ago (2015-05-01 07:54:45 UTC) #9
Chris Palmer
LGTM. I can't log in as palmer@chromium.org right now (office move!), but you can TBR ...
5 years, 7 months ago (2015-05-01 18:22:21 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-04 07:17:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086073004/180001
5 years, 7 months ago (2015-05-08 04:41:49 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:180001)
5 years, 7 months ago (2015-05-08 04:58:38 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 04:59:52 UTC) #17
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/78b9d632216a85390766a1fa04f321954e4a1da2
Cr-Commit-Position: refs/heads/master@{#328930}

Powered by Google App Engine
This is Rietveld 408576698