Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 1086073002: Start the documentation preview server on localhost only by default. (Closed)

Created:
5 years, 8 months ago by pneubeck (no reviews)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start the documentation preview server on localhost only by default. Committed: https://crrev.com/9e9cef7d066f973f92a7f07be86859ba3174b3aa Cr-Commit-Position: refs/heads/master@{#325405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/extensions/docs/server2/preview.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pneubeck (no reviews)
It's rather insecure to open ports on all interfaces. Not sure whether I can actually ...
5 years, 8 months ago (2015-04-15 08:48:21 UTC) #2
not at google - send to devlin
lgtm
5 years, 8 months ago (2015-04-15 16:21:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086073002/1
5 years, 8 months ago (2015-04-16 08:33:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 08:57:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 08:58:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e9cef7d066f973f92a7f07be86859ba3174b3aa
Cr-Commit-Position: refs/heads/master@{#325405}

Powered by Google App Engine
This is Rietveld 408576698