Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1086063003: Correctly handle clearing of deprecated field types. (Closed)

Created:
5 years, 8 months ago by ulan
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly handle clearing of deprecated field types. BUG=v8:4027 LOG=NO Committed: https://crrev.com/68a7773e0f218def0f39a1ee37972695f09a7c4e Cr-Commit-Position: refs/heads/master@{#27837}

Patch Set 1 #

Total comments: 2

Patch Set 2 : just do one GC in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M src/objects.cc View 1 chunk +11 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-4027.js View 1 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL
5 years, 8 months ago (2015-04-15 09:06:56 UTC) #2
Jakob Kummerow
LGTM https://codereview.chromium.org/1086063003/diff/1/test/mjsunit/regress/regress-4027.js File test/mjsunit/regress/regress-4027.js (right): https://codereview.chromium.org/1086063003/diff/1/test/mjsunit/regress/regress-4027.js#newcode55 test/mjsunit/regress/regress-4027.js:55: for (var i = 0; i < 3; ...
5 years, 8 months ago (2015-04-15 09:25:16 UTC) #3
ulan
https://codereview.chromium.org/1086063003/diff/1/test/mjsunit/regress/regress-4027.js File test/mjsunit/regress/regress-4027.js (right): https://codereview.chromium.org/1086063003/diff/1/test/mjsunit/regress/regress-4027.js#newcode55 test/mjsunit/regress/regress-4027.js:55: for (var i = 0; i < 3; i++) ...
5 years, 8 months ago (2015-04-15 09:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086063003/20001
5 years, 8 months ago (2015-04-15 09:32:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 09:55:45 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 09:55:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68a7773e0f218def0f39a1ee37972695f09a7c4e
Cr-Commit-Position: refs/heads/master@{#27837}

Powered by Google App Engine
This is Rietveld 408576698