content/browser/devtools/renderer_overrides_handler.cc - Issue 108603005: Update uses of Value in chromeos/, cloud_print/, components/, content/ to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/renderer_overrides_handler.cc

Issue 108603005: Update uses of Value in chromeos/, cloud_print/, components/, content/ to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/devtools_tracing_handler.cc ('k') | content/browser/devtools/renderer_overrides_handler_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/renderer_overrides_handler.cc

diff --git a/content/browser/devtools/renderer_overrides_handler.cc b/content/browser/devtools/renderer_overrides_handler.cc

index 4901f34cc12bf5e90438138a598d6a076ad6dd0f..f8d02115e98f4017a7ac2caee5ab12a6e5e5adec 100644

--- a/content/browser/devtools/renderer_overrides_handler.cc

+++ b/content/browser/devtools/renderer_overrides_handler.cc

@@ -367,7 +367,7 @@ RendererOverridesHandler::PageGetNavigationHistory(

result->SetInteger(

devtools::Page::getNavigationHistory::kResponseCurrentIndex,

controller.GetCurrentEntryIndex());

- ListValue* entries = new ListValue();

+ base::ListValue* entries = new base::ListValue();

for (int i = 0; i != controller.GetEntryCount(); ++i) {

const NavigationEntry* entry = controller.GetEntryAtIndex(i);

base::DictionaryValue* entry_value = new base::DictionaryValue();