content/browser/devtools/devtools_protocol.cc - Issue 108603005: Update uses of Value in chromeos/, cloud_print/, components/, content/ to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_protocol.cc

Issue 108603005: Update uses of Value in chromeos/, cloud_print/, components/, content/ to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_host_browsertest.cc ('k') | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_protocol.cc

diff --git a/content/browser/devtools/devtools_protocol.cc b/content/browser/devtools/devtools_protocol.cc

index e0e544e54c49b4e99392952d439809b675a526ad..f3c393d2c0e92627651cb0959be86d555c09f384 100644

--- a/content/browser/devtools/devtools_protocol.cc

+++ b/content/browser/devtools/devtools_protocol.cc

@@ -275,11 +275,11 @@ base::DictionaryValue* DevToolsProtocol::ParseMessage(

std::string* error_response) {

int parse_error_code;

std::string error_message;

- scoped_ptr<Value> message(

+ scoped_ptr<base::Value> message(

base::JSONReader::ReadAndReturnError(

json, 0, &parse_error_code, &error_message));

- if (!message || !message->IsType(Value::TYPE_DICTIONARY)) {

+ if (!message || !message->IsType(base::Value::TYPE_DICTIONARY)) {

scoped_refptr<Response> response =

new Response(0, kErrorParseError, error_message);

if (error_response)