Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1085993004: Implement support for file: includes in OWNERS files. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Implement support for file: includes in OWNERS files. This CL implements support for file: include lines in OWNERS files, both as top-level directives and as per-file directives. The paths can be either relative or absolute. Examples of lines in OWNERS files: file:test/OWNERS (relative, top-level) file://content/OWNERS (absolute, top-level) per-file mock_impl.h=file:test/OWNERS (relative, per-file) per-file mock_impl.h=file://content/OWNERS (absolute, per-file) A whole series of tests to cover this feature have been added to owners_unittest.py as well. BUG=119396, 147633 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294854

Patch Set 1 #

Patch Set 2 : add a noparent tset #

Total comments: 11

Patch Set 3 : #

Patch Set 4 : minor cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -4 lines) Patch
M owners.py View 1 2 3 6 chunks +51 lines, -4 lines 0 comments Download
M testing_support/filesystem_mock.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/owners_unittest.py View 1 5 chunks +84 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Peter Beverloo
+brettw and dpranke WDYT? I'm sure there are rough edges, but this should be a ...
5 years, 8 months ago (2015-04-15 16:35:09 UTC) #2
Dirk Pranke
Thanks for working on this! I think it'll make a number of people quite happy. ...
5 years, 8 months ago (2015-04-15 19:42:37 UTC) #3
Peter Beverloo
Thanks for the review! I haven't yet applied the comment change since I left the ...
5 years, 8 months ago (2015-04-15 20:04:31 UTC) #4
Dirk Pranke
this is what I get for not really staring at the patch, given that it's ...
5 years, 8 months ago (2015-04-15 20:52:03 UTC) #5
Peter Beverloo
https://codereview.chromium.org/1085993004/diff/20001/owners.py File owners.py (right): https://codereview.chromium.org/1085993004/diff/20001/owners.py#newcode303 owners.py:303: return dirpath, owners_path On 2015/04/15 20:52:03, Dirk Pranke wrote: ...
5 years, 8 months ago (2015-04-15 20:57:09 UTC) #6
Peter Beverloo
https://codereview.chromium.org/1085993004/diff/20001/owners.py File owners.py (right): https://codereview.chromium.org/1085993004/diff/20001/owners.py#newcode51 owners.py:51: "//" it is considered to be an absolute path, ...
5 years, 8 months ago (2015-04-16 09:54:06 UTC) #7
Dirk Pranke
lgtm, thanks!
5 years, 8 months ago (2015-04-16 16:27:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085993004/60001
5 years, 8 months ago (2015-04-16 16:38:46 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 16:42:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294854

Powered by Google App Engine
This is Rietveld 408576698