chrome/renderer/resources/plugin_poster.html - Issue 1085993003: Plugin Power Saver: Make posters work right when image is 404 Not Found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/plugin_poster.html

Issue 1085993003: Plugin Power Saver: Make posters work right when image is 404 Not Found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0263-plugin-power-saver-heuristic-tests

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/plugin_poster.html

diff --git a/chrome/renderer/resources/plugin_poster.html b/chrome/renderer/resources/plugin_poster.html

index 0a3742a6f92cbc460058ab157445b6d0e95a5a81..5c3c07fc7d5e4eb2f59421b541df13b836b66069 100644

--- a/chrome/renderer/resources/plugin_poster.html

+++ b/chrome/renderer/resources/plugin_poster.html

@@ -45,6 +45,7 @@ document.onkeydown = function(e) {

#poster {

height: 100%;

width: 100%;

+ object-fit: contain;

z-index: 1;

}

@@ -63,7 +64,8 @@ document.onkeydown = function(e) {

- <img id="poster" i18n-values="srcset:poster">

+ <img id="poster" i18n-values="srcset:poster"

+ onerror="this.style.display = 'none';">

Dan Beam 2015/04/17 03:53:53 nit: instead of this.style.display = 'none'; U

tommycli 2015/04/22 20:11:33 Done.

<div id="inner_container"

i18n-values=".style.width:visibleWidth;.style.height:visibleHeight">

« chrome/renderer/resources/plugin_placeholders.css ('K') | « chrome/renderer/resources/plugin_placeholders.css ('k') | no next file » | no next file with comments »