Chromium Code Reviews Chromium Code Reviews
Issue 1085993003:
Plugin Power Saver: Make posters work right when image is 404 Not Found. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@0263-plugin-power-saver-heuristic-tests| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <meta name="viewport" content="width=device-width, user-scalable=no"> | 5 <meta name="viewport" content="width=device-width, user-scalable=no"> |
| 6 <script> | 6 <script> |
| 7 function notifyDidFinishLoading() { | 7 function notifyDidFinishLoading() { |
| 8 if (plugin.didFinishLoading) | 8 if (plugin.didFinishLoading) |
| 9 plugin.didFinishLoading(); | 9 plugin.didFinishLoading(); |
| 10 } | 10 } |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 38 opacity: 0.8; | 38 opacity: 0.8; |
| 39 } | 39 } |
| 40 | 40 |
| 41 #plugin_icon:hover { | 41 #plugin_icon:hover { |
| 42 opacity: 0.95; | 42 opacity: 0.95; |
| 43 } | 43 } |
| 44 | 44 |
| 45 #poster { | 45 #poster { |
| 46 height: 100%; | 46 height: 100%; |
| 47 width: 100%; | 47 width: 100%; |
| 48 object-fit: contain; | |
| 48 z-index: 1; | 49 z-index: 1; |
| 49 } | 50 } |
| 50 | 51 |
| 51 #inner_container { | 52 #inner_container { |
| 52 height: 100%; | 53 height: 100%; |
| 53 width: 100%; | 54 width: 100%; |
| 54 position: relative; | 55 position: relative; |
| 55 } | 56 } |
| 56 | 57 |
| 57 #inner { | 58 #inner { |
| 58 margin-top: -25px; | 59 margin-top: -25px; |
| 59 } | 60 } |
| 60 </style> | 61 </style> |
| 61 <base i18n-values="href:baseurl"> | 62 <base i18n-values="href:baseurl"> |
| 62 </head> | 63 </head> |
| 63 | 64 |
| 64 <body onload="notifyDidFinishLoading();"> | 65 <body onload="notifyDidFinishLoading();"> |
| 65 <div i18n-values="title:name" id="outer" onclick="plugin.load()"> | 66 <div i18n-values="title:name" id="outer" onclick="plugin.load()"> |
| 66 <img id="poster" i18n-values="srcset:poster"> | 67 <img id="poster" i18n-values="srcset:poster" |
| 68 onerror="this.style.display = 'none';"> | |
|
Dan Beam
2015/04/17 03:53:53
nit: instead of
this.style.display = 'none';
U
tommycli
2015/04/22 20:11:33
Done.
| |
| 67 <div id="shielding"> | 69 <div id="shielding"> |
| 68 <div id="inner_container" | 70 <div id="inner_container" |
| 69 i18n-values=".style.width:visibleWidth;.style.height:visibleHeight"> | 71 i18n-values=".style.width:visibleWidth;.style.height:visibleHeight"> |
| 70 <div id="inner"> | 72 <div id="inner"> |
| 71 <img id="plugin_icon" src="plugin_power_saver_play.png" /> | 73 <img id="plugin_icon" src="plugin_power_saver_play.png" /> |
| 72 </div> | 74 </div> |
| 73 </div> | 75 </div> |
| 74 </div> | 76 </div> |
| 75 </div> | 77 </div> |
| 76 </body> | 78 </body> |
| 77 </html> | 79 </html> |
| OLD | NEW |
