Source/core/frame/LocalDOMWindow.h - Issue 1085973003: Make error messages for cross-domain access OOPIF-friendly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.h

Issue 1085973003: Make error messages for cross-domain access OOPIF-friendly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase (pull in CL to print errors on calling window) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalDOMWindow.h

diff --git a/Source/core/frame/LocalDOMWindow.h b/Source/core/frame/LocalDOMWindow.h

index 22d235d211e8dee6ff0aefde0a1eba20fc1ab01d..882acac6de428500a347714d7d988ac24e0a5d35 100644

--- a/Source/core/frame/LocalDOMWindow.h

+++ b/Source/core/frame/LocalDOMWindow.h

@@ -147,8 +147,6 @@ public:

int webkitRequestAnimationFrame(FrameRequestCallback*) override;

void cancelAnimationFrame(int id) override;

void schedulePostMessage(PassRefPtrWillBeRawPtr<MessageEvent>, LocalDOMWindow* source, SecurityOrigin* target, PassRefPtrWillBeRawPtr<ScriptCallStack> stackTrace);

- String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override;

- String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) override;

void registerProperty(DOMWindowProperty*);

void unregisterProperty(DOMWindowProperty*);

@@ -195,8 +193,6 @@ public:

void willDetachDocumentFromFrame();

- bool isInsecureScriptAccess(DOMWindow& callingWindow, const String& urlString) override;

EventQueue* eventQueue() const;

void enqueueWindowEvent(PassRefPtrWillBeRawPtr<Event>);

void enqueueDocumentEvent(PassRefPtrWillBeRawPtr<Event>);

« Source/bindings/core/v8/BindingSecurity.cpp ('K') | « Source/core/frame/DOMWindow.cpp ('k') | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »