Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: Source/core/frame/DOMWindow.h

Issue 1085973003: Make error messages for cross-domain access OOPIF-friendly. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase (pull in CL to print errors on calling window) Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindow.h
diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h
index 399cec0a49383c2a42a63d2e9c9e0546c48a4dd2..96a8fd58f3db283a9bda67ca02386241581397f4 100644
--- a/Source/core/frame/DOMWindow.h
+++ b/Source/core/frame/DOMWindow.h
@@ -181,11 +181,9 @@ public:
void postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, const String& targetOrigin, LocalDOMWindow* source, ExceptionState&);
- // FIXME: These should be non-virtual, but this is blocked on the security
- // origin replication work.
- virtual String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) = 0;
- virtual String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) = 0;
- virtual bool isInsecureScriptAccess(DOMWindow& callingWindow, const String& urlString);
+ String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);
+ String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);
+ bool isInsecureScriptAccess(LocalDOMWindow& callingWindow, const String& urlString);
// FIXME: When this DOMWindow is no longer the active DOMWindow (i.e.,
// when its document is no longer the document that is displayed in its

Powered by Google App Engine
This is Rietveld 408576698