Make error messages for cross-domain access OOPIF-friendly.

Source/bindings/core/v8/BindingSecurity.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 72 matching lines @@
 
 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* target, SecurityReportingOption reportingOption)
 {
     if (!target || !target->isLocalFrame())
         return false;
     return canAccessDocument(isolate, toLocalFrame(target)->document(), reportingOption);
 }
 
 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* target, ExceptionState& exceptionState)
 {
-    if (!target || !target->isLocalFrame())
+    if (!target)
         return false;
+
+    if (target->isRemoteFrame() && target->domWindow()) {

[haraken, 2015/04/16 03:41:19]

Shouldn't this be something like:

if (target->isRemoteFrame()) {
  if (target->domWindow()) {
    throwSecurityError(...);
  }
  return false;
}

?

[alexmos, 2015/04/17 16:49:06]

Yes.  I've already removed this code though, as this will now be handled by
canAccessFrame(), the OOPIF-friendly replacement for canAccessDocument.

+        LocalDOMWindow* callingWindow = callingDOMWindow(isolate);
+        exceptionState.throwSecurityError(target->domWindow()->sanitizedCrossDomainAccessErrorMessage(callingWindow), target->domWindow()->crossDomainAccessErrorMessage(callingWindow));
+        return false;
+    }
+
     return canAccessDocument(isolate, toLocalFrame(target)->document(), exceptionState);
 }
 
 bool BindingSecurity::shouldAllowAccessToNode(v8::Isolate* isolate, Node* target, ExceptionState& exceptionState)
 {
     return target && canAccessDocument(isolate, &target->document(), exceptionState);
 }
 
 }