Make error messages for cross-domain access OOPIF-friendly.

Source/core/frame/DOMWindow.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DOMWindow_h
 #define DOMWindow_h
 
 #include "core/CoreExport.h"
 #include "core/events/EventTarget.h"
 #include "core/frame/DOMWindowBase64.h"
@@ skipping 163 matching lines @@
     void captureEvents() { }
     void releaseEvents() { }
 
     // FIXME: This handles both window[index] and window.frames[index]. However,
     // the spec exposes window.frames[index] across origins but not
     // window[index]...
     DOMWindow* anonymousIndexedGetter(uint32_t) const;
 
     void postMessage(PassRefPtr<SerializedScriptValue> message, const MessagePortArray*, const String& targetOrigin, LocalDOMWindow* source, ExceptionState&);
 
-    // FIXME: These should be non-virtual, but this is blocked on the security
-    // origin replication work.
-    virtual String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) = 0;
-    virtual String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow) = 0;
-    virtual bool isInsecureScriptAccess(DOMWindow& callingWindow, const String& urlString);
+    String sanitizedCrossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);
+    String crossDomainAccessErrorMessage(LocalDOMWindow* callingWindow);
+    bool isInsecureScriptAccess(LocalDOMWindow& callingWindow, const String& urlString);

[alexmos, 2015/04/15 17:15:17]

All of the call sites passed in a LocalDOMWindow, and I don't know why the
callingWindow could be a RemoteDOMWindow, so I changed the signature.  If
there's a good reason to keep it as DOMWindow, please let me know.

Actually, I don't quite understand the point of having this function.  It seems
that all call sites (setLocation, LocalDOMWindow::open, createWindow) call
canNavigate() before calling this.  Do you know what this adds over the security
checks done by canNavigate?

[dcheng, 2015/04/15 21:03:49]

LocalDOMWindow makes more sense.
Are you sure all locations call canNavigate() first? It seems like window.open()
might not, even though it ends up calling this function.

 
     // FIXME: When this DOMWindow is no longer the active DOMWindow (i.e.,
     // when its document is no longer the document that is displayed in its
     // frame), we would like to zero out m_frame to avoid being confused
     // by the document that is currently active in m_frame.
     // See https://bugs.webkit.org/show_bug.cgi?id=62054
     bool isCurrentlyDisplayedInFrame() const;
 
     void resetLocation();
 
@@ skipping 25 matching lines @@
     // implementation details to scripts.
     bool m_windowIsClosing;
 
 private:
     mutable RefPtrWillBeMember<Location> m_location;
 };
 
 } // namespace blink
 
 #endif // DOMWindow_h