Make error messages for cross-domain access OOPIF-friendly.

Source/bindings/core/v8/BindingSecurity.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 67 matching lines @@
             frame->localDOMWindow()->printErrorMessage(targetDocument->domWindow()->crossDomainAccessErrorMessage(callingWindow));
     }
 
     return false;
 }
 
 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* target, SecurityReportingOption reportingOption)
 {
     if (!target || !target->isLocalFrame())
         return false;
+
     return canAccessDocument(isolate, toLocalFrame(target)->document(), reportingOption);
 }
 
 bool BindingSecurity::shouldAllowAccessToFrame(v8::Isolate* isolate, Frame* target, ExceptionState& exceptionState)
 {
-    if (!target || !target->isLocalFrame())
+    if (!target)
         return false;
+
+    if (target->isRemoteFrame() && target->domWindow()) {
+        LocalDOMWindow* callingWindow = callingDOMWindow(isolate);
+        exceptionState.throwSecurityError(target->domWindow()->sanitizedCrossDomainAccessErrorMessage(callingWindow), target->domWindow()->crossDomainAccessErrorMessage(callingWindow));
+        return false;
+    }
+
     return canAccessDocument(isolate, toLocalFrame(target)->document(), exceptionState);

[alexmos, 2015/04/15 17:15:17]

It seems like I can also go further and turn canAccessDocument into
canAccessFrame, which would let me do throwSecurityError() in just one location.
 Do you think that's a good idea?

Another question: should RemoteFrames support printErrorMessage()?  For some
reason, canAccessDocument and other calls like canNavigate() print access denied
errors on the target frame, not the calling frame.  Alternatively, we could
reverse these to print the error on the calling frame (which should always be
local): there's a FIXME in LocalFrame::printNavigationErrorMessage to that
effect.

[dcheng, 2015/04/15 21:03:49]

Yes, let's try to simplify this.
I think it's more useful to log on the calling frame. Maybe haraken@ knows of a
historical reason why we log it on the target window instead?

 }
 
 bool BindingSecurity::shouldAllowAccessToNode(v8::Isolate* isolate, Node* target, ExceptionState& exceptionState)
 {
     return target && canAccessDocument(isolate, &target->document(), exceptionState);
 }
 
 }