Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1085973002: Add a flag to app_shell that allows roaming on cellular networks (Closed)

Created:
5 years, 8 months ago by jsimmons
Modified:
5 years, 8 months ago
Reviewers:
James Cook, Daniel Erat
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, joth
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to app_shell that allows roaming on cellular networks BUG=chrome-os-partner:37102 Committed: https://crrev.com/97ecc6e577ce2019720e72564e6a3a0efad25f3f Cr-Commit-Position: refs/heads/master@{#325525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M extensions/shell/browser/shell_browser_main_parts.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_network_controller_chromeos.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_network_controller_chromeos.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/shell/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/common/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
James Cook
LGTM Sorry for the delay - for some reason I didn't get an email from ...
5 years, 8 months ago (2015-04-16 21:17:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085973002/1
5 years, 8 months ago (2015-04-16 21:40:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 22:15:41 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 22:16:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97ecc6e577ce2019720e72564e6a3a0efad25f3f
Cr-Commit-Position: refs/heads/master@{#325525}

Powered by Google App Engine
This is Rietveld 408576698