Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1085883002: change hairline procs to take array of points (Closed)

Created:
5 years, 8 months ago by reed1
Modified:
5 years, 8 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change hairline procs to take array of points BUG=skia: Committed: https://skia.googlesource.com/skia/+/5dc6b7d1a8bc591d62366ff83c434ff74f3e10fc

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -179 lines) Patch
M src/core/SkDraw.cpp View 1 4 chunks +10 lines, -15 lines 0 comments Download
M src/core/SkScan.h View 3 chunks +13 lines, -4 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 2 chunks +61 lines, -63 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 9 chunks +102 lines, -97 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085883002/1
5 years, 8 months ago (2015-04-14 17:00:10 UTC) #2
reed1
precursor to large hairline opt (that also changes pixels slightly) that needs vector access to ...
5 years, 8 months ago (2015-04-14 17:02:19 UTC) #4
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-14 17:06:36 UTC) #6
caryclark
lgtm https://codereview.chromium.org/1085883002/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/1085883002/diff/1/src/core/SkDraw.cpp#newcode1876 src/core/SkDraw.cpp:1876: return doAntiAlias ? &SkScan::AntiHairLine : SkScan::HairLine; why the ...
5 years, 8 months ago (2015-04-14 17:12:35 UTC) #7
reed1
https://codereview.chromium.org/1085883002/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/1085883002/diff/1/src/core/SkDraw.cpp#newcode1876 src/core/SkDraw.cpp:1876: return doAntiAlias ? &SkScan::AntiHairLine : SkScan::HairLine; On 2015/04/14 17:12:35, ...
5 years, 8 months ago (2015-04-14 17:34:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085883002/20001
5 years, 8 months ago (2015-04-14 17:34:26 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 17:40:50 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5dc6b7d1a8bc591d62366ff83c434ff74f3e10fc

Powered by Google App Engine
This is Rietveld 408576698