Issue 1085873002: Only accept inherit/initial/unset in single value declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1085873002: Only accept inherit/initial/unset in single value declarations (Closed)

Created:
5 years, 8 months ago by rwlbuis

Modified:
5 years, 8 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Only accept inherit/initial/unset in single value declarations Do not accept inherit/initial/unset in value list longer than one. Previously "margin: inherit 5px" would be discarded correctly, but "margin: 5px inherit" would be accepted erroneously. This patch now fixes the latter. Behavior matches Firefox. BUG=476868 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193740

Patch Set 1 #

Patch Set 2 : Add subtests #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -5 lines)			Patch
M	LayoutTests/css3/supports-dom-api.html	View	1	1 chunk	+61 lines, -0 lines	0 comments	Download
M	LayoutTests/css3/supports-dom-api-expected.txt	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085873002/20001

5 years, 8 months ago (2015-04-15 00:57:54 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-15 02:09:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193740

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages