Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: build/common.gypi

Issue 1085843004: mac: Add the flag "-gline-tables-only" to reduce dSYM size. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from thakis. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5112 matching lines...) Expand 10 before | Expand all | Expand 10 after
5123 'OTHER_CFLAGS': [ 5123 'OTHER_CFLAGS': [
5124 # Someday this can be replaced by an 'GCC_STRICT_ALIASING': 'NO' 5124 # Someday this can be replaced by an 'GCC_STRICT_ALIASING': 'NO'
5125 # xcode_setting, but not until all downstream projects' mac bots are 5125 # xcode_setting, but not until all downstream projects' mac bots are
5126 # using xcode >= 4.6, because that's when the default value of the 5126 # using xcode >= 4.6, because that's when the default value of the
5127 # flag in the compiler switched. Pre-4.6, the value 'NO' for that 5127 # flag in the compiler switched. Pre-4.6, the value 'NO' for that
5128 # setting is a no-op as far as xcode is concerned, but the compiler 5128 # setting is a no-op as far as xcode is concerned, but the compiler
5129 # behaves differently based on whether -fno-strict-aliasing is 5129 # behaves differently based on whether -fno-strict-aliasing is
5130 # specified or not. 5130 # specified or not.
5131 '-fno-strict-aliasing', # See http://crbug.com/32204. 5131 '-fno-strict-aliasing', # See http://crbug.com/32204.
5132 ], 5132 ],
5133 'conditions': [
5134 ['branding=="Chrome" and buildtype=="Official"', {
5135 'OTHER_CFLAGS': [
erikchen 2015/04/23 01:20:36 I don't understand GYP. I figured that this would
Nico 2015/04/23 01:26:24 gyp merges lists by appending them. This is docume
erikchen 2015/04/23 01:57:49 I see. It was unclear to me that lists got merged
5136 # The Google Chrome Framework dSYM generated by dsymutil has gro wn
5137 # larger than 4GB, which dsymutil can't handle. Reduce the amoun t
5138 # of debug symbols.
5139 '-gline-tables-only', # See http://crbug.com/479841
5140 ]
5141 }],
5142 ],
5143
5133 }, 5144 },
5134 'target_conditions': [ 5145 'target_conditions': [
5135 ['_type=="executable"', { 5146 ['_type=="executable"', {
5136 'postbuilds': [ 5147 'postbuilds': [
5137 { 5148 {
5138 # Arranges for data (heap) pages to be protected against 5149 # Arranges for data (heap) pages to be protected against
5139 # code execution when running on Mac OS X 10.7 ("Lion"), and 5150 # code execution when running on Mac OS X 10.7 ("Lion"), and
5140 # ensures that the position-independent executable (PIE) bit 5151 # ensures that the position-independent executable (PIE) bit
5141 # is set for ASLR when running on Mac OS X 10.5 ("Leopard"). 5152 # is set for ASLR when running on Mac OS X 10.5 ("Leopard").
5142 'variables': { 5153 'variables': {
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
5187 _type=="loadable_module") and mac_strip!=0', { 5198 _type=="loadable_module") and mac_strip!=0', {
5188 'target_conditions': [ 5199 'target_conditions': [
5189 ['mac_real_dsym == 1', { 5200 ['mac_real_dsym == 1', {
5190 # To get a real .dSYM bundle produced by dsymutil, set the 5201 # To get a real .dSYM bundle produced by dsymutil, set the
5191 # debug information format to dwarf-with-dsym. Since 5202 # debug information format to dwarf-with-dsym. Since
5192 # strip_from_xcode will not be used, set Xcode to do the 5203 # strip_from_xcode will not be used, set Xcode to do the
5193 # stripping as well. 5204 # stripping as well.
5194 'configurations': { 5205 'configurations': {
5195 'Release_Base': { 5206 'Release_Base': {
5196 'xcode_settings': { 5207 'xcode_settings': {
5197 'DEBUG_INFORMATION_FORMAT': 'dwarf-with-dsym', 5208 'DEBUG_INFORMATION_FORMAT': 'dwarf-with-dsym',
Nico 2015/04/23 01:26:24 Probably best to put this here, next to the dsymut
erikchen 2015/04/23 01:56:05 This is a good suggestion, not bikeshedding. Thank
5198 'DEPLOYMENT_POSTPROCESSING': 'YES', 5209 'DEPLOYMENT_POSTPROCESSING': 'YES',
5199 'STRIP_INSTALLED_PRODUCT': 'YES', 5210 'STRIP_INSTALLED_PRODUCT': 'YES',
5200 'conditions': [ 5211 'conditions': [
5201 # Only strip non-ASan builds. 5212 # Only strip non-ASan builds.
5202 ['asan==0', { 5213 ['asan==0', {
5203 'target_conditions': [ 5214 'target_conditions': [
5204 ['_type=="shared_library" or _type=="loadable_module "', { 5215 ['_type=="shared_library" or _type=="loadable_module "', {
5205 # The Xcode default is to strip debugging symbols 5216 # The Xcode default is to strip debugging symbols
5206 # only (-S). Local symbols should be stripped as 5217 # only (-S). Local symbols should be stripped as
5207 # well, which will be handled by -x. Xcode will 5218 # well, which will be handled by -x. Xcode will
(...skipping 919 matching lines...) Expand 10 before | Expand all | Expand 10 after
6127 # settings in target dicts. SYMROOT is a special case, because many other 6138 # settings in target dicts. SYMROOT is a special case, because many other
6128 # Xcode variables depend on it, including variables such as 6139 # Xcode variables depend on it, including variables such as
6129 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6140 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6130 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6141 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6131 # files to appear (when present) in the UI as actual files and not red 6142 # files to appear (when present) in the UI as actual files and not red
6132 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6143 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6133 # and therefore SYMROOT, needs to be set at the project level. 6144 # and therefore SYMROOT, needs to be set at the project level.
6134 'SYMROOT': '<(DEPTH)/xcodebuild', 6145 'SYMROOT': '<(DEPTH)/xcodebuild',
6135 }, 6146 },
6136 } 6147 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698