Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1085843003: Revert of Web MIDI: split build rules for media/midi (Closed)

Created:
5 years, 8 months ago by aboxhall
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, yhirano
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Web MIDI: split build rules for media/midi (patchset #19 id:340001 of https://codereview.chromium.org/1065743003/) Reason for revert: Very sorry to have to revert this after so much work, but midi_unittests has been consistently broken on Android Tests bot e.g. https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25597 Original issue's description: > Web MIDI: split build rules for media/midi > > Split MIDI related stuffs from media as a component in build files. > Also, MIDI related unit tests are split into midi_unittests. > > BUG=475869 > TEST=git cl try > > Committed: https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331 > Cr-Commit-Position: refs/heads/master@{#326247} TBR=phajdan.jr@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,boliu@chromium.org,damienv@chromium.org,jam@chromium.org,thestig@chromium.org,lcwu@chromium.org,gunsch@chromium.org,toyoshim@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475869 Committed: https://crrev.com/60006f2c430e17fc8338ff370a1c88cdc61b7f07 Cr-Commit-Position: refs/heads/master@{#326343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+713 lines, -1294 lines) Patch
M BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M android_webview/android_webview.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 14 chunks +0 lines, -15 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/gn_migration.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M media/BUILD.gn View 8 chunks +66 lines, -2 lines 0 comments Download
M media/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/UsbMidiDeviceAndroid.java View 1 chunk +295 lines, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/UsbMidiDeviceFactoryAndroid.java View 1 chunk +264 lines, -0 lines 0 comments Download
M media/base/android/media_jni_registrar.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/media.gyp View 7 chunks +55 lines, -0 lines 0 comments Download
D media/midi/BUILD.gn View 1 chunk +0 lines, -163 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceAndroid.java View 1 chunk +0 lines, -295 lines 0 comments Download
D media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java View 1 chunk +0 lines, -264 lines 0 comments Download
D media/midi/midi.gyp View 1 chunk +0 lines, -222 lines 0 comments Download
D media/midi/midi_jni_registrar.h View 1 chunk +0 lines, -21 lines 0 comments Download
D media/midi/midi_jni_registrar.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/midi/midi_manager_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/midi/midi_scheduler.h View 2 chunks +1 line, -2 lines 0 comments Download
D media/midi/midi_unittests.isolate View 1 chunk +0 lines, -63 lines 0 comments Download
M media/midi/usb_midi_device_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/midi/usb_midi_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 19 chunks +0 lines, -57 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 4 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +0 lines, -9 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +0 lines, -30 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aboxhall
Created Revert of Web MIDI: split build rules for media/midi
5 years, 8 months ago (2015-04-22 18:22:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085843003/1
5 years, 8 months ago (2015-04-22 18:25:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 18:28:05 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 18:28:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60006f2c430e17fc8338ff370a1c88cdc61b7f07
Cr-Commit-Position: refs/heads/master@{#326343}

Powered by Google App Engine
This is Rietveld 408576698