Chromium Code Reviews

Unified Diff: Source/core/dom/ChildNode.idl

Issue 1085843002: Implement DOM: prepend, append, before, after & replaceWith (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: Source/core/dom/ChildNode.idl
diff --git a/Source/core/dom/ChildNode.idl b/Source/core/dom/ChildNode.idl
index 8c2f9f3ac096a566b4af2a8f7ad23645dcfc7512..af17cdf55ff884bdad6462328485a9386b275e55 100644
--- a/Source/core/dom/ChildNode.idl
+++ b/Source/core/dom/ChildNode.idl
@@ -26,9 +26,8 @@
LegacyTreatAsPartialInterface,
NoInterfaceObject, // Always used on target of 'implements'
] interface ChildNode {
- // [Unscopeable] void before((Node or DOMString)... nodes);
- // [Unscopeable] void after((Node or DOMString)... nodes);
- // [Unscopeable] void replaceWith((Node or DOMString)... nodes);
- // TODO(philipj): remove() should be [Unscopeable]. crbug.com/462916
- [RaisesException, CustomElementCallbacks] void remove();
+ [RaisesException, Unscopeable, CustomElementCallbacks] void before((Node or DOMString) ... Nodes);
philipj_slow 2015/04/29 13:16:57 I like to put the per-spec bits first, so [Unscope
Paritosh Kumar 2015/06/08 12:21:24 Done.
+ [RaisesException, Unscopeable, CustomElementCallbacks] void after((Node or DOMString)... nodes);
+ [RaisesException, Unscopeable, CustomElementCallbacks] void replaceWith((Node or DOMString)... nodes);
+ [RaisesException, Unscopeable, CustomElementCallbacks] void remove();
};

Powered by Google App Engine