LayoutTests/fast/dom/Comment/after.html - Issue 1085843002: Implement DOM: prepend, append, before, after & replaceWith

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Comment/after.html

Issue 1085843002: Implement DOM: prepend, append, before, after & replaceWith (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="../script-tests/childnode-after.js"></script>
	philipj_slow 2015/04/29 13:16:57 This pattern is a bit atypical for testharness.js This pattern is a bit atypical for testharness.js tests unless there is shared code between tests. You could just inline the tests in this file to make the test self-contained. (Anticipating the feedback you'd get if upstreaming to web-platform-tests.) Paritosh Kumar 2015/06/08 12:21:24 Done. Thanks. Show quoted text On 2015/04/29 13:16:57, philipj wrote: > This pattern is a bit atypical for testharness.js tests unless there is shared > code between tests. You could just inline the tests in this file to make the > test self-contained. (Anticipating the feedback you'd get if upstreaming to > web-platform-tests.) Done. Thanks.
	5 <script>

	6 var node, parentNode;

	7 setup(function() {

	8 node = document.createComment("node");
	philipj_slow 2015/04/29 13:16:57 Indentation should be 2 or 4 spaces. (I tend to us Indentation should be 2 or 4 spaces. (I tend to use 2 spaces in tests intended for web-platform-tests.) Paritosh Kumar 2015/06/08 12:21:24 Done. Show quoted text On 2015/04/29 13:16:57, philipj wrote: > Indentation should be 2 or 4 spaces. (I tend to use 2 spaces in tests intended > for web-platform-tests.) Done.
	9 parentNode = document.createElement("div");

	10 });

	11 testAfter(node, parentNode, "comment");

	12 </script>

	13 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/Comment/before.html » ('j') | Source/core/dom/ChildNode.idl » ('J')