content/browser/frame_host/DEPS - Issue 1085783002: Replace image_messages.h with Mojo service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/frame_host/DEPS

Issue 1085783002: Replace image_messages.h with Mojo service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot unit_tests error Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # The frame_host files should only call upwards in the layering via the	2 # The frame_host files should only call upwards in the layering via the

3 # delegate interfaces.	3 # delegate interfaces.

4 "-content/browser/web_contents",	4 "-content/browser/web_contents",

5 "-content/public/browser/web_contents.h",	5 "-content/public/browser/web_contents.h",

6 "-content/public/browser/web_contents_delegate.h",	6 "-content/public/browser/web_contents_delegate.h",

7 "-content/public/browser/web_contents_view.h",	7 "-content/public/browser/web_contents_view.h",

8 ]	8 ]

9	9

10 specific_include_rules = {	10 specific_include_rules = {

11 ".*_(unit\|browser)test\.cc": [	11 ".*_(unit\|browser)test\.cc": [

12 "+content/browser/web_contents",	12 "+content/browser/web_contents",

13 "+content/public/browser/web_contents.h",	13 "+content/public/browser/web_contents.h",

14 "+content/public/browser/web_contents_delegate.h",	14 "+content/public/browser/web_contents_delegate.h",

15 ],	15 ],

16 ".*interstitial_page_impl\.cc": [	16 ".*interstitial_page_impl\.cc": [

17 # TODO(nasko): This should be removed once we remove	17 # TODO(nasko): This should be removed once we remove

18 # WebContentsObserver as the method of telling interstitial pages to	18 # WebContentsObserver as the method of telling interstitial pages to

19 # clean themselves up.	19 # clean themselves up.

20 "+content/browser/web_contents",	20 "+content/browser/web_contents",

21 "+content/public/browser/web_contents_delegate.h",	21 "+content/public/browser/web_contents_delegate.h",

22 ],	22 ],

	23 ".*render_frame_host_impl\.h": [

	24 # To get typedef of WebContents::ImageDownloadCallback.

	25 "+content/public/browser/web_contents.h",
	nasko 2015/07/02 08:41:07 This seems wrong. The frame_host layer doesn't and This seems wrong. The frame_host layer doesn't and shouldn't know about the web_contents layer. You should define the callback type in a common location and have WebContents and this layer both consume it.
	26 ],

23 }	27 }

OLD	NEW

« no previous file with comments | « content/browser/BUILD.gn ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')