Chromium Code Reviews Chromium Code Reviews
Issue
1085733002:
Subzero: Auto-detect cmake versus autoconf LLVM build. (Closed)
DescriptionSubzero: Auto-detect cmake versus autoconf LLVM build.
The CMAKE=1 option is no longer needed.
Pretty much all the tools we need are now in pnacl_newlib_raw/bin, so use PNACL_BIN_PATH set to that instead of using LLVM_BIN_PATH and BINUTILS_BIN_PATH.
However, for the autoconf build, libgtest and libtest_main and clang-format are only under the llvm_x86_64_linux_work directory, so they need special casing. This also means that you have to actually do an LLVM build and not blow away the work directory in order to "make check-unit" or "make format".
BUG= none
R=jvoung@chromium.org
Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=0a9e12617f007a24efe5cb70dbebf53f45abbd3e
Patch Set 1 #Patch Set 2 : Better explanation of the hack #Patch Set 3 : Make a best effort at locating clang-format #Patch Set 4 : Combine {LLVM,BINUTILS}_BIN_PATH into PNACL_BIN_PATH, and similar #
Total comments: 4
Patch Set 5 : Fix the sb build libs #
Messages
Total messages: 5 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
