Issue 108573008: [Telemetry] Don't restore command lines that will break Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108573008: [Telemetry] Don't restore command lines that will break Chrome. (Closed)

Created:
7 years ago by tonyg

Modified:
7 years ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org, jamesr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Don't restore command lines that will break Chrome. A common problem is that if something goes wrong with Telemetry, the command line file which points all network traffic at Web Page Replay can be left in place which results in users not understanding why no pages will load. So if we detect this setting, simply clear the file. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242109

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/108573008/1

7 years ago (2013-12-20 01:31:52 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108429

7 years ago (2013-12-20 10:34:00 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/108573008/1

7 years ago (2013-12-20 14:51:31 UTC) #5

Message was sent while issue was closed.

Change committed as 242109

Expand Messages | Collapse Messages