Issue 108573002: [XHR] remove now-unnecessary RaisesException attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108573002: [XHR] remove now-unnecessary RaisesException attributes. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
tyoshino (SeeGerritForStatus), Nate Chapin, abarth-chromium

CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

[XHR] remove now-unnecessary RaisesException attributes. A handful of getters and methods now follow the spec and no longer throw: synchronize their signatures and underlying IDL to reflect that by removing [RaisesException] use. R=tyoshino@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163491

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	Source/core/xml/XMLHttpRequest.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

sof

Just a bit of code hygiene; please take a look when/if you have a moment.

7 years ago (2013-12-06 17:18:08 UTC) #1

sof

On 2013/12/07 02:26:48, tyoshino wrote: > lgtm Needs a core/OWNERS stamp of approval? :)

7 years ago (2013-12-09 22:54:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/108573002/1

7 years ago (2013-12-10 01:12:26 UTC) #5

Message was sent while issue was closed.

Change committed as 163491