lib/runtime/dart/convert.js - Issue 1085723002: fixes for angular hello: String + and disable broken arg parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart/convert.js

Issue 1085723002: fixes for angular hello: String + and disable broken arg parsing (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/runtime/dart/convert.js

diff --git a/lib/runtime/dart/convert.js b/lib/runtime/dart/convert.js

index 171551aaeb07340cca0bb781aba7aeed2036180c..2cc625c97e8d6b14bfbcd0ebbd02980f517a2840 100644

--- a/lib/runtime/dart/convert.js

+++ b/lib/runtime/dart/convert.js

@@ -1400,7 +1400,7 @@ var convert;

}

addSlice(chunk, start, end, isLast) {

if (this[_carry] != null) {

- chunk = core.String['+'](this[_carry], chunk.substring(start, end));

+ chunk = dart.notNull(this[_carry]) + dart.notNull(chunk.substring(start, end));

start = 0;

end = chunk.length;

this[_carry] = null;

« no previous file with comments | « lib/runtime/dart/collection.js ('k') | lib/runtime/dart/core.js » ('j') | lib/src/codegen/js_codegen.dart » ('J')