fixes for angular hello: String + and disable broken arg parsing

lib/runtime/dart/_js_helper.js

 var _js_helper;
 (function(exports) {
   'use strict';
   class NoSideEffects extends core.Object {
     NoSideEffects() {
     }
   }
   class NoThrows extends core.Object {
     NoThrows() {
     }
@@ skipping 75 matching lines @@
       get(key) {
         if (!dart.notNull(this.containsKey(key)))
           return null;
         return dart.as(this[_fetch](key), V);
       }
       [_fetch](key) {
         return jsPropertyAccess(this[_jsObject], dart.as(key, core.String));
       }
       forEach(f) {
         let keys = this[_keys];
-        for (let i = 0; i['<'](dart.dload(keys, 'length')); i = dart.notNull(i) + 1) {
+        for (let i = 0; core.int['<'](i, dart.dload(keys, 'length')); i = dart.notNull(i) + 1) {
           let key = dart.dindex(keys, i);
           f(dart.as(key, K), dart.as(this[_fetch](key), V));
         }
       }
       get keys() {
         return new (_ConstantMapKeyIterable$(K))(this);
       }
       get values() {
         return new (_internal.MappedIterable$(K, V))(this[_keys], dart.as((key => this[_fetch](key)).bind(this), dart.functionType(V, [K])));
       }
@@ skipping 263 matching lines @@
   function initNativeDispatchContinue() {
     exports.dispatchRecordsForInstanceTags = Object.create(null);
     exports.interceptorsForUncacheableTags = Object.create(null);
     initHooks();
     let map = exports.interceptorsByTag;
     let tags = Object.getOwnPropertyNames(map);
     if (typeof window != "undefined") {
       let context = window;
       let fun = function() {
       };
-      for (let i = 0; i['<'](dart.dload(tags, 'length')); i = dart.notNull(i) + 1) {
+      for (let i = 0; core.int['<'](i, dart.dload(tags, 'length')); i = dart.notNull(i) + 1) {
         let tag = dart.dindex(tags, i);
         let proto = dart.dcall(exports.prototypeForTagFunction, tag);
         if (proto != null) {
           let interceptorClass = map[tag];
           let record = makeDefaultDispatchRecord(tag, interceptorClass, proto);
           if (record != null) {
             _interceptors.setDispatchProperty(proto, record);
             fun.prototype = proto;
           }
         }
       }
     }
-    for (let i = 0; i['<'](dart.dload(tags, 'length')); i = dart.notNull(i) + 1) {
+    for (let i = 0; core.int['<'](i, dart.dload(tags, 'length')); i = dart.notNull(i) + 1) {
       let tag = tags[i];
       if (/^[A-Za-z_]/.test(tag)) {
         let interceptorClass = propertyGet(map, tag);
-        propertySet(map, core.String['+'](INSTANCE_CACHED_MARK, tag), interceptorClass);
-        propertySet(map, core.String['+'](UNCACHED_MARK, tag), interceptorClass);
-        propertySet(map, core.String['+'](LEAF_MARK, tag), interceptorClass);
-        propertySet(map, core.String['+'](INTERIOR_MARK, tag), interceptorClass);
-        propertySet(map, core.String['+'](DISCRIMINATED_MARK, tag), interceptorClass);
+        propertySet(map, dart.notNull(INSTANCE_CACHED_MARK) + dart.notNull(tag), interceptorClass);
+        propertySet(map, dart.notNull(UNCACHED_MARK) + dart.notNull(tag), interceptorClass);
+        propertySet(map, dart.notNull(LEAF_MARK) + dart.notNull(tag), interceptorClass);
+        propertySet(map, dart.notNull(INTERIOR_MARK) + dart.notNull(tag), interceptorClass);
+        propertySet(map, dart.notNull(DISCRIMINATED_MARK) + dart.notNull(tag), interceptorClass);
       }
     }
   }
   // Function initHooks: () → void
   function initHooks() {
     let hooks = _baseHooks();
     let _fallbackConstructorHooksTransformer = _fallbackConstructorHooksTransformerGenerator(_constructorNameFallback);
     hooks = applyHooksTransformer(_fallbackConstructorHooksTransformer, hooks);
     hooks = applyHooksTransformer(_firefoxHooksTransformer, hooks);
     hooks = applyHooksTransformer(_ieHooksTransformer, hooks);
@@ skipping 472 matching lines @@
     toString() {
       if (this[_unmangledName] != null)
         return this[_unmangledName];
       let unmangledName = _js_names.unmangleAllIdentifiersIfPreservedAnyways(this[_typeName]);
       return this[_unmangledName] = unmangledName;
     }
     get hashCode() {
       return this[_typeName].hashCode;
     }
     ['=='](other) {
-      return dart.is(other, TypeImpl) && dart.notNull(dart.equals(this[_typeName], dart.dload(other, _typeName)));
+      return dart.is(other, TypeImpl) && dart.equals(this[_typeName], dart.dload(other, _typeName));
     }
   }
   TypeImpl[dart.implements] = () => [core.Type];
   class TypeVariable extends core.Object {
     TypeVariable(owner, name, bound) {
       this.owner = owner;
       this.name = name;
       this.bound = bound;
     }
   }
@@ skipping 180 matching lines @@
     }
     return true;
   }
   // Function computeSignature: (dynamic, dynamic, dynamic) → dynamic
   function computeSignature(signature, context, contextName) {
     let typeArguments = getRuntimeTypeArguments(context, contextName);
     return invokeOn(signature, context, typeArguments);
   }
   // Function isSupertypeOfNull: (dynamic) → bool
   function isSupertypeOfNull(type) {
-    return dart.notNull(type == null) || dart.notNull(getConstructorName(type) == _foreign_helper.JS_OBJECT_CLASS_NAME()) || dart.notNull(getConstructorName(type) == _foreign_helper.JS_NULL_CLASS_NAME());
+    return dart.notNull(type == null) || getConstructorName(type) == _foreign_helper.JS_OBJECT_CLASS_NAME() || getConstructorName(type) == _foreign_helper.JS_NULL_CLASS_NAME();
   }
   // Function checkSubtypeOfRuntimeType: (dynamic, dynamic) → bool
   function checkSubtypeOfRuntimeType(o, t) {
     if (o == null)
       return isSupertypeOfNull(t);
     if (t == null)
       return true;
     let rti = getRuntimeTypeInfo(o);
     o = _interceptors.getInterceptor(o);
     let type = o.constructor;
@@ skipping 611 matching lines @@
   // Function getMetadata: (int) → dynamic
   function getMetadata(index) {
     let metadata = _foreign_helper.JS_EMBEDDED_GLOBAL('', _js_embedded_names.METADATA);
     return metadata[index];
   }
   let _throwFormatException = Symbol('_throwFormatException');
   let _fromCharCodeApply = Symbol('_fromCharCodeApply');
   let _mangledNameMatchesType = Symbol('_mangledNameMatchesType');
   class Primitives extends core.Object {
     static initializeStatics(id) {
-      Primitives.mirrorFunctionCacheName = core.String['+'](Primitives.mirrorFunctionCacheName, `_${id}`);
-      Primitives.mirrorInvokeCacheName = core.String['+'](Primitives.mirrorInvokeCacheName, `_${id}`);
+      Primitives.mirrorFunctionCacheName = dart.notNull(Primitives.mirrorFunctionCacheName) + `_${id}`;
+      Primitives.mirrorInvokeCacheName = dart.notNull(Primitives.mirrorInvokeCacheName) + `_${id}`;
     }
     static objectHashCode(object) {
       let hash = dart.as(object.$identityHash, core.int);
       if (hash == null) {
         hash = Math.random() * 0x3fffffff | 0;
         object.$identityHash = hash;
       }
       return hash;
     }
     static [_throwFormatException](string) {
@@ skipping 53 matching lines @@
     static parseDouble(source, handleError) {
       checkString(source);
       if (handleError == null)
         handleError = dart.as(Primitives[_throwFormatException], dart.functionType(core.double, [core.String]));
       if (!/^\s*[+-]?(?:Infinity|NaN|(?:\.\d+|\d+(?:\.\d*)?)(?:[eE][+-]?\d+)?)\s*$/.test(source)) {
         return handleError(source);
       }
       let result = parseFloat(source);
       if (result.isNaN) {
         let trimmed = source.trim();
-        if (dart.notNull(trimmed == 'NaN') || dart.notNull(trimmed == '+NaN') || dart.notNull(trimmed == '-NaN')) {
+        if (trimmed == 'NaN' || trimmed == '+NaN' || trimmed == '-NaN') {
           return result;
         }
         return handleError(source);
       }
       return result;
     }
     static formatType(className, typeArguments) {
       return _js_names.unmangleAllIdentifiersIfPreservedAnyways(`${className}${joinArguments(typeArguments, 0)}`);
     }
     static objectTypeName(object) {
@@ skipping 63 matching lines @@
       return result;
     }
     static stringFromCodePoints(codePoints) {
       let a = new core.List$(core.int).from([]);
       for (let i of dart.as(codePoints, core.Iterable)) {
         if (!(typeof i == 'number'))
           throw new core.ArgumentError(i);
         if (dart.dsend(i, '<=', 65535)) {
           a[core.$add](dart.as(i, core.int));
         } else if (dart.dsend(i, '<=', 1114111)) {
-          a[core.$add](55296['+'](dart.dsend(dart.dsend(dart.dsend(i, '-', 65536), '>>', 10), '&', 1023)));
-          a[core.$add](56320['+'](dart.dsend(i, '&', 1023)));
+          a[core.$add](core.int['+'](55296, dart.dsend(dart.dsend(dart.dsend(i, '-', 65536), '>>', 10), '&', 1023)));
+          a[core.$add](core.int['+'](56320, dart.dsend(i, '&', 1023)));
         } else {
           throw new core.ArgumentError(i);
         }
       }
       return Primitives[_fromCharCodeApply](a);
     }
     static stringFromCharCodes(charCodes) {
       for (let i of dart.as(charCodes, core.Iterable)) {
         if (!(typeof i == 'number'))
           throw new core.ArgumentError(i);
         if (dart.dsend(i, '<', 0))
           throw new core.ArgumentError(i);
         if (dart.dsend(i, '>', 65535))
           return Primitives.stringFromCodePoints(charCodes);
       }
       return Primitives[_fromCharCodeApply](dart.as(charCodes, core.List$(core.int)));
     }
     static stringFromCharCode(charCode) {
-      if (0['<='](charCode)) {
+      if (core.int['<='](0, charCode)) {
         if (dart.dsend(charCode, '<=', 65535)) {
           return String.fromCharCode(charCode);
         }
         if (dart.dsend(charCode, '<=', 1114111)) {
           let bits = dart.dsend(charCode, '-', 65536);
-          let low = 56320['|'](dart.dsend(bits, '&', 1023));
-          let high = 55296['|'](dart.dsend(bits, '>>', 10));
+          let low = core.int['|'](56320, dart.dsend(bits, '&', 1023));
+          let high = core.int['|'](55296, dart.dsend(bits, '>>', 10));
           return String.fromCharCode(high, low);
         }
       }
       throw new core.RangeError.range(dart.as(charCode, core.num), 0, 1114111);
     }
     static stringConcatUnchecked(string1, string2) {
       return _foreign_helper.JS_STRING_CONCAT(string1, string2);
     }
     static flattenString(str) {
       return str.charCodeAt(0) == 0 ? str : str;
@@ skipping 1451 matching lines @@
           let rti = dart.dsend(this.namedParameters[name], 'toRti');
           namedRti[name] = rti;
         }
         result[_foreign_helper.JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG()] = namedRti;
       }
       return result;
     }
     static listToRti(list) {
       list = list;
       let result = [];
-      for (let i = 0; i['<'](dart.dload(list, 'length')); i = dart.notNull(i) + 1) {
+      for (let i = 0; core.int['<'](i, dart.dload(list, 'length')); i = dart.notNull(i) + 1) {
         result.push(dart.dsend(dart.dindex(list, i), 'toRti'));
       }
       return result;
     }
     toString() {
       let result = '(';
       let needsComma = false;
       if (this.parameterTypes != null) {
         for (let i = 0; dart.notNull(i) < dart.notNull(this.parameterTypes[core.$length]); i = dart.notNull(i) + 1) {
           let type = this.parameterTypes[core.$get](i);
           if (needsComma) {
-            result = core.String['+'](result, ', ');
+            result = dart.notNull(result) + ', ';
           }
-          result = core.String['+'](result, `${type}`);
+          result = dart.notNull(result) + `${type}`;
           needsComma = true;
         }
       }
       if (dart.notNull(this.optionalParameterTypes != null) && !dart.notNull(this.optionalParameterTypes[core.$isEmpty])) {
         if (needsComma) {
-          result = core.String['+'](result, ', ');
+          result = dart.notNull(result) + ', ';
         }
         needsComma = false;
-        result = core.String['+'](result, '[');
+        result = dart.notNull(result) + '[';
         for (let i = 0; dart.notNull(i) < dart.notNull(this.optionalParameterTypes[core.$length]); i = dart.notNull(i) + 1) {
           let type = this.optionalParameterTypes[core.$get](i);
           if (needsComma) {
-            result = core.String['+'](result, ', ');
+            result = dart.notNull(result) + ', ';
           }
-          result = core.String['+'](result, `${type}`);
+          result = dart.notNull(result) + `${type}`;
           needsComma = true;
         }
-        result = core.String['+'](result, ']');
+        result = dart.notNull(result) + ']';
       } else if (this.namedParameters != null) {
         if (needsComma) {
-          result = core.String['+'](result, ', ');
+          result = dart.notNull(result) + ', ';
         }
         needsComma = false;
-        result = core.String['+'](result, '{');
+        result = dart.notNull(result) + '{';
         let keys = _js_names.extractKeys(this.namedParameters);
         for (let i = 0; dart.notNull(i) < dart.notNull(keys[core.$length]); i = dart.notNull(i) + 1) {
           let name = keys[core.$get](i);
           if (needsComma) {
-            result = core.String['+'](result, ', ');
+            result = dart.notNull(result) + ', ';
           }
           let rti = dart.dsend(this.namedParameters[name], 'toRti');
-          result = core.String['+'](result, `${rti} ${name}`);
+          result = dart.notNull(result) + `${rti} ${name}`;
           needsComma = true;
         }
-        result = core.String['+'](result, '}');
+        result = dart.notNull(result) + '}';
       }
-      result = core.String['+'](result, `) -> ${this.returnType}`);
+      result = dart.notNull(result) + `) -> ${this.returnType}`;
       return result;
     }
   }
   RuntimeFunctionType.inAssert = false;
   // Function buildFunctionType: (dynamic, dynamic, dynamic) → RuntimeFunctionType
   function buildFunctionType(returnType, parameterTypes, optionalParameterTypes) {
     return new RuntimeFunctionType(dart.as(returnType, RuntimeType), dart.as(parameterTypes, core.List$(RuntimeType)), dart.as(optionalParameterTypes, core.List$(RuntimeType)), null);
   }
   // Function buildNamedFunctionType: (dynamic, dynamic, dynamic) → RuntimeFunctionType
   function buildNamedFunctionType(returnType, parameterTypes, namedParameters) {
@@ skipping 171 matching lines @@
         throw 'bad type';
       }
     }
     toString() {
       if (this[_cachedToString] != null)
         return this[_cachedToString];
       let s = "(";
       let sep = '';
       if (this[_hasArguments]) {
         for (let argument of this[_arguments]) {
-          s = core.String['+'](s, sep);
-          s = core.String['+'](s, this[_convert](argument));
+          s = dart.notNull(s) + dart.notNull(sep);
+          s = dart.notNull(s) + dart.notNull(this[_convert](argument));
           sep = ', ';
         }
       }
       if (this[_hasOptionalArguments]) {
-        s = core.String['+'](s, `${sep}[`);
+        s = dart.notNull(s) + `${sep}[`;
         sep = '';
         for (let argument of this[_optionalArguments]) {
-          s = core.String['+'](s, sep);
-          s = core.String['+'](s, this[_convert](argument));
+          s = dart.notNull(s) + dart.notNull(sep);
+          s = dart.notNull(s) + dart.notNull(this[_convert](argument));
           sep = ', ';
         }
-        s = core.String['+'](s, ']');
+        s = dart.notNull(s) + ']';
       }
       if (this[_hasNamedArguments]) {
-        s = core.String['+'](s, `${sep}{`);
+        s = dart.notNull(s) + `${sep}{`;
         sep = '';
         for (let name of _js_names.extractKeys(this[_namedArguments])) {
-          s = core.String['+'](s, sep);
-          s = core.String['+'](s, `${name}: `);
-          s = core.String['+'](s, this[_convert](this[_namedArguments][name]));
+          s = dart.notNull(s) + dart.notNull(sep);
+          s = dart.notNull(s) + `${name}: `;
+          s = dart.notNull(s) + dart.notNull(this[_convert](this[_namedArguments][name]));
           sep = ', ';
         }
-        s = core.String['+'](s, '}');
+        s = dart.notNull(s) + '}';
       }
-      s = core.String['+'](s, ') -> ');
+      s = dart.notNull(s) + ') -> ';
       if (this[_isVoid]) {
-        s = core.String['+'](s, 'void');
+        s = dart.notNull(s) + 'void';
       } else if (this[_hasReturnType]) {
-        s = core.String['+'](s, this[_convert](this[_returnType]));
+        s = dart.notNull(s) + dart.notNull(this[_convert](this[_returnType]));
       } else {
-        s = core.String['+'](s, 'dynamic');
+        s = dart.notNull(s) + 'dynamic';
       }
       return this[_cachedToString] = `${s}`;
     }
   }
   class UnimplementedNoSuchMethodError extends core.Error {
     UnimplementedNoSuchMethodError(message$) {
       this[_message] = message$;
       super.Error();
     }
     toString() {
@@ skipping 372 matching lines @@
   exports.jsonEncodeNative = jsonEncodeNative;
   exports.getIsolateAffinityTag = getIsolateAffinityTag;
   exports.LoadLibraryFunctionType = LoadLibraryFunctionType;
   exports.DeferredLoadCallback = DeferredLoadCallback;
   exports.loadDeferredLibrary = loadDeferredLibrary;
   exports.MainError = MainError;
   exports.missingMain = missingMain;
   exports.badMain = badMain;
   exports.mainHasTooManyParameters = mainHasTooManyParameters;
 })(_js_helper || (_js_helper = {}));