fixes for angular hello: String + and disable broken arg parsing

fixes for angular hello: String + and disable broken arg parsing

R=jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/24da83ce6b846fc8f9c3ed9118426aee50cb47db

[Jennifer Messerly, 2015-04-13 23:14:16]

Patchset #1 (id:1) has been deleted

[Jennifer Messerly, 2015-04-13 23:15:00]

jmesserly@google.com changed reviewers:
+ jacobr@google.com

[Jennifer Messerly, 2015-04-13 23:15:27]

note: many more fixes needed for angular hello. this just gets it a little
closer :)

[Jacob, 2015-04-13 23:23:16]

lgtm

https://codereview.chromium.org/1085723002/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1085723002/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:1452: bool typeIsPrimitiveInJS(DartType t) =>
(rules.isIntType(t) ||
was !rules.isDynamic(t) never needed?

https://codereview.chromium.org/1085723002/diff/20001/test/codegen/expect/fie...
File test/codegen/expect/fieldtest.js (right):

https://codereview.chromium.org/1085723002/diff/20001/test/codegen/expect/fie...
test/codegen/expect/fieldtest.js:46: return 'life, ' + 'the universe ' + 'and
everything';
42

[Jennifer Messerly, 2015-04-14 17:44:02]

https://codereview.chromium.org/1085723002/diff/20001/lib/src/codegen/js_code...
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1085723002/diff/20001/lib/src/codegen/js_code...
lib/src/codegen/js_codegen.dart:1452: bool typeIsPrimitiveInJS(DartType t) =>
(rules.isIntType(t) ||
On 2015/04/13 23:23:16, Jacob wrote:
> was !rules.isDynamic(t) never needed?

yeah, it didn't make sense to me (how can int/double/bool/num/String be
dynamic?!). Now I'm second guessing myself. Maybe this was for the
`options.ignoreTypes` flag which generates everything as `dynamic`. if true that
means: we aren't testing the flag at all, and it was broken already in other
places.
I filed https://github.com/dart-lang/dev_compiler/issues/134 to track

https://codereview.chromium.org/1085723002/diff/20001/test/codegen/expect/fie...
File test/codegen/expect/fieldtest.js (right):

https://codereview.chromium.org/1085723002/diff/20001/test/codegen/expect/fie...
test/codegen/expect/fieldtest.js:46: return 'life, ' + 'the universe ' + 'and
everything';
On 2015/04/13 23:23:16, Jacob wrote:
> 42

yeah, our constant folding isn't good enough yet. It would take ~7.5 million
years with the current Deep Thought engine, so I left it disabled for now, but
we can enable in a future CL.

[Jennifer Messerly, 2015-04-15 01:04:18]

Committed patchset #3 (id:60001) manually as
24da83ce6b846fc8f9c3ed9118426aee50cb47db (presubmit successful).