[Android] DeviceUtils change to make Install work without md5 binary.

[Android] DeviceUtils change to make Install work without md5 binary.

I will want to use the device_util Install function on Chrome
builds downloaded from Google storage. There is no garuntee in this
case that the md5sum_bin_host has been built, or even that the
BUILDTYPE environment variable has been set. This change is to
simply catch those exceptions, and just install everything if
md5 isn't availible.

BUG=463498
Committed: https://crrev.com/d84193aa868e644f4913cd8f5ddd5569dcb4263d
Cr-Commit-Position: refs/heads/master@{#327597}

[mikecase (-- gone --), 2015-04-13 22:48:58]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, perezju@chromium.org

[jbudorick, 2015-04-13 22:51:47]

in title: "Device util change" -> "[Android] DeviceUtils change"

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/con...
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/con...
build/android/pylib/constants.py:222: raise EnvironmentError(
Not sure about this exception type.

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:821: try:
This should be done in md5sum.py, not in device_utils.py.

Additionally, it should cover both the host calculation and the device
calculation.

[perezju, 2015-04-14 10:45:30]

Thanks for looking into this! It's one of the most annoying bugs that hit you
when trying to test something locally.

https://codereview.chromium.org/1085713002/diff/40001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/40001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:824: logging.info('md5sum_bin_host
might not be built, '
maybe logging.warning, and include the exception message so we know what went
wrong, e.g.

except EnvironmentError as exc:
  logging.warning('md5sum_bin_host error: %s', exc)

https://codereview.chromium.org/1085713002/diff/40001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:832: device_hash_tuples =
md5sum.CalculateDeviceMd5Sums(
I guess we also want this wrapped on a similar try-except block?

[mikecase (-- gone --), 2015-04-14 16:18:38]

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/con...
File build/android/pylib/constants.py (right):

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/con...
build/android/pylib/constants.py:222: raise EnvironmentError(
On 2015/04/13 22:51:47, jbudorick wrote:
> Not sure about this exception type.

Couldn't think of a better alternative. Its an error about an environment
variable not being set so EnvironmentError seems to fit.

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/20001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:821: try:
On 2015/04/13 22:51:47, jbudorick wrote:
> This should be done in md5sum.py, not in device_utils.py.
> 
> Additionally, it should cover both the host calculation and the device
> calculation.

Now both the call to md5sum.CalculateHostMd5Sums and
md5sum.CalculateDeviceMd5Sums in device_utils are in the try catch.

In md5sum.py I added a couple lines to check if the necessary files were built,
and if not, raise a IOError with an appropriate message.

https://codereview.chromium.org/1085713002/diff/40001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/40001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:824: logging.info('md5sum_bin_host
might not be built, '
On 2015/04/14 10:45:29, perezju wrote:
> maybe logging.warning, and include the exception message so we know what went
> wrong, e.g.
> 
> except EnvironmentError as exc:
>   logging.warning('md5sum_bin_host error: %s', exc)

Done.

[perezju, 2015-04-15 09:36:18]

lgtm with nit.

just check with john if there are further comments to address

https://codereview.chromium.org/1085713002/diff/80001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/80001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:830: logging.warning('Error
calculating md5: %s' % e)
nit: should be logging.warning('Error calculating md5: %s', e) [note the comma,
preferred instead of %; this was discussed somewhere, but forgot the link]

[mikecase (-- gone --), 2015-04-21 16:54:33]

https://codereview.chromium.org/1085713002/diff/80001/build/android/pylib/dev...
File build/android/pylib/device/device_utils.py (right):

https://codereview.chromium.org/1085713002/diff/80001/build/android/pylib/dev...
build/android/pylib/device/device_utils.py:830: logging.warning('Error
calculating md5: %s' % e)
On 2015/04/15 09:36:18, perezju wrote:
> nit: should be logging.warning('Error calculating md5: %s', e) [note the
comma,
> preferred instead of %; this was discussed somewhere, but forgot the link]

Done.

[jbudorick, 2015-04-28 20:26:45]

Sorry for taking a little while to look at this. It now needs to be rebased.

[mikecase (-- gone --), 2015-04-29 20:49:28]

On 2015/04/28 20:26:45, jbudorick wrote:
> Sorry for taking a little while to look at this. It now needs to be rebased.

Rebased. Please take a look when you get the chance.

[jbudorick, 2015-04-29 20:51:30]

lgtm

[mikecase (-- gone --), 2015-04-29 20:52:19]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-04-29 20:52:19]

The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org
Link to the patchset: https://codereview.chromium.org/1085713002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-04-29 20:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085713002/120001

[commit-bot: I haz the power, 2015-04-29 22:11:30]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-04-29 22:12:26]

Patchset 7 (id:??) landed as
https://crrev.com/d84193aa868e644f4913cd8f5ddd5569dcb4263d
Cr-Commit-Position: refs/heads/master@{#327597}