compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java - Issue 10857041: Fix for issue 3550

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

Issue 10857041: Fix for issue 3550 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

===================================================================

--- compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (revision 10845)

+++ compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java (working copy)

@@ -720,7 +720,7 @@

@Override

public Void visitVariableStatement(DartVariableStatement node) {

Modifiers modifiers = node.getModifiers();

- if (modifiers.isStatic() && modifiers.isFinal()) {

+ if (modifiers.isConstant() || (modifiers.isStatic() && modifiers.isFinal())) {

for (DartVariable variable : node.getVariables()) {

if (variable.getValue() != null) {

checkConstantExpression(variable.getValue());