Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1085703002: Add an ONC property for proactive key caching. (Closed)

Created:
5 years, 8 months ago by Matthew Wein
Modified:
5 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an ONC property for proactive key caching with documentation. BUG=472741 TEST=None Committed: https://crrev.com/b605e72e1b07f9b7501882c31ec422d05c1794bf Cr-Commit-Position: refs/heads/master@{#326738}

Patch Set 1 #

Patch Set 2 : Add tests for converting in both directions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chromeos/network/onc/onc_signature.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/test/data/network/shill_wifi_clientcert.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_wifi_clientcert.onc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/test/data/network/wifi_clientcert_with_cert_pems.onc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/docs/onc_spec.html View 1 chunk +10 lines, -0 lines 0 comments Download
M components/onc/onc_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/onc/onc_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085703002/40001
5 years, 8 months ago (2015-04-16 20:52:20 UTC) #5
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 8 months ago (2015-04-16 20:52:22 UTC) #7
stevenjb
+pneubeck@ FYI lgtm
5 years, 8 months ago (2015-04-24 03:15:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085703002/60001
5 years, 8 months ago (2015-04-24 03:22:37 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 8 months ago (2015-04-24 04:16:05 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b605e72e1b07f9b7501882c31ec422d05c1794bf Cr-Commit-Position: refs/heads/master@{#326738}
5 years, 8 months ago (2015-04-24 04:17:02 UTC) #20
pneubeck (no reviews)
the bug number seems to be wrong
5 years, 8 months ago (2015-04-24 07:21:32 UTC) #21
Matthew Wein
5 years, 8 months ago (2015-04-24 17:44:09 UTC) #22
Message was sent while issue was closed.
Fixed associated bug number.

Powered by Google App Engine
This is Rietveld 408576698