Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1085613002: Remove unneeded 'google_chrome_strings.h' from all cc files (Closed)

Created:
5 years, 8 months ago by gburanov
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tapted, michaelpg+watch-options_chromium.org, Matt Giuca, grt+watch_chromium.org, tfarina, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

We need to remove "google_chrome_strings.h" from everywhere There is no need in it because we have 'chromium_strings.h" already. Please take a look at following topic https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/a2XQpRBrKNw R=pkasting@chromium.org Committed: https://crrev.com/a0094e60790be818b61843809edb3d30d4e384f9 Cr-Commit-Position: refs/heads/master@{#325251}

Patch Set 1 #

Messages

Total messages: 24 (8 generated)
gburanov
5 years, 8 months ago (2015-04-13 12:28:27 UTC) #2
tfarina
The subject line does not match the CL description. Could you improve both? Also describe ...
5 years, 8 months ago (2015-04-13 13:12:58 UTC) #4
tfarina
On Mon, Apr 13, 2015 at 10:12 AM, <tfarina@chromium.org> wrote: > The subject line does ...
5 years, 8 months ago (2015-04-13 13:14:40 UTC) #5
gburanov
done!
5 years, 8 months ago (2015-04-13 13:53:38 UTC) #6
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-13 18:51:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085613002/1
5 years, 8 months ago (2015-04-13 19:51:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/55977)
5 years, 8 months ago (2015-04-13 20:04:21 UTC) #11
gburanov
5 years, 8 months ago (2015-04-14 13:06:54 UTC) #13
gburanov
5 years, 8 months ago (2015-04-14 13:08:58 UTC) #15
mattm
safe_browsing lgtm. (Note for future reference: when adding reviewers, it's good form to specify which ...
5 years, 8 months ago (2015-04-14 20:04:00 UTC) #16
gburanov
On 2015/04/14 20:04:00, mattm wrote: > safe_browsing lgtm. (Note for future reference: when adding reviewers, ...
5 years, 8 months ago (2015-04-14 20:33:32 UTC) #17
Peter Kasting
On 2015/04/14 20:33:32, gburanov wrote: > On 2015/04/14 20:04:00, mattm wrote: > > safe_browsing lgtm. ...
5 years, 8 months ago (2015-04-14 20:34:18 UTC) #18
engedy
LGTM on chrome/browser/profile_resetter. Thanks for doing this clean-up!
5 years, 8 months ago (2015-04-15 13:59:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085613002/1
5 years, 8 months ago (2015-04-15 14:20:29 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 15:53:28 UTC) #23
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 15:54:06 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0094e60790be818b61843809edb3d30d4e384f9
Cr-Commit-Position: refs/heads/master@{#325251}

Powered by Google App Engine
This is Rietveld 408576698