Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1085603003: DevTools: fix min-height of "text-button" devtools custom element. (Closed)

Created:
5 years, 8 months ago by lushnikov
Modified:
5 years, 8 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: fix min-height of "text-button" devtools custom element. The min-height got overriden via general changes in inspectorCommon.css This was regressed in r193665. All other min-height/min-width rules in devtools seem to be OK due to higher selector specificity. BUG=477193 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193880

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/ui/textButton.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
lushnikov
5 years, 8 months ago (2015-04-16 13:00:06 UTC) #1
sergeyv
lgtm
5 years, 8 months ago (2015-04-16 13:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085603003/1
5 years, 8 months ago (2015-04-16 13:12:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 15:44:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193880

Powered by Google App Engine
This is Rietveld 408576698