Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1085583006: iOS platform scripts to be used by buildbots (Closed)

Created:
5 years, 8 months ago by stephana-chromium
Modified:
5 years, 7 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added ios_install #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : Fixed ios_run_skia script #

Patch Set 11 : Adding blacklists #

Patch Set 12 : Blacklist 2 #

Patch Set 13 : Blacklist 3 #

Patch Set 14 : Rebase #

Patch Set 15 : Ignoring WritePixel test and fixed ios_pull script #

Patch Set 16 : Fixed shell script #

Patch Set 17 : Added change to gyp that fixes link problem #

Patch Set 18 : Rebase #

Patch Set 19 : #

Patch Set 20 : #

Total comments: 9

Patch Set 21 : Addressed comments and rebase #

Total comments: 2

Patch Set 22 : Removed trailing white spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -141 lines) Patch
M gyp/iOSShell.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +2 lines, -1 line 0 comments Download
A + platform_tools/ios/bin/ios_cat_file View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +8 lines, -5 lines 0 comments Download
A + platform_tools/ios/bin/ios_install View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -2 lines 0 comments Download
M platform_tools/ios/bin/ios_mkdir View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +2 lines, -0 lines 0 comments Download
A + platform_tools/ios/bin/ios_mount View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 2 chunks +6 lines, -6 lines 0 comments Download
D platform_tools/ios/bin/ios_mount.sh View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M platform_tools/ios/bin/ios_ninja View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -4 lines 0 comments Download
M platform_tools/ios/bin/ios_path_exists View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +7 lines, -4 lines 0 comments Download
D platform_tools/ios/bin/ios_pull.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -16 lines 0 comments Download
M platform_tools/ios/bin/ios_pull_if_needed View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -4 lines 0 comments Download
M platform_tools/ios/bin/ios_push_file View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +4 lines, -3 lines 0 comments Download
M platform_tools/ios/bin/ios_push_if_needed View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +7 lines, -0 lines 0 comments Download
A + platform_tools/ios/bin/ios_rm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +5 lines, -2 lines 0 comments Download
D platform_tools/ios/bin/ios_rmdir View 1 2 3 4 1 chunk +0 lines, -12 lines 0 comments Download
M platform_tools/ios/bin/ios_run_skia View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +6 lines, -12 lines 0 comments Download
M platform_tools/ios/bin/ios_setup.sh View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 5 chunks +47 lines, -39 lines 0 comments Download
A + platform_tools/ios/bin/ios_umount View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +6 lines, -1 line 0 comments Download
D platform_tools/ios/bin/ios_umount.sh View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M tools/dm_flags.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
stephana-chromium
5 years, 7 months ago (2015-05-05 12:38:03 UTC) #2
borenet
https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp File gyp/iOSShell.gyp (right): https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp#newcode1 gyp/iOSShell.gyp:1: # Copyright 2015 Google Inc. Intentional? https://codereview.chromium.org/1085583006/diff/380001/platform_tools/ios/bin/ios_cat_file File platform_tools/ios/bin/ios_cat_file ...
5 years, 7 months ago (2015-05-05 12:59:02 UTC) #3
stephana-chromium
https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp File gyp/iOSShell.gyp (right): https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp#newcode1 gyp/iOSShell.gyp:1: # Copyright 2015 Google Inc. On 2015/05/05 12:59:02, borenet ...
5 years, 7 months ago (2015-05-05 13:30:25 UTC) #4
borenet
LGTM https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp File gyp/iOSShell.gyp (right): https://codereview.chromium.org/1085583006/diff/380001/gyp/iOSShell.gyp#newcode1 gyp/iOSShell.gyp:1: # Copyright 2015 Google Inc. On 2015/05/05 13:30:25, ...
5 years, 7 months ago (2015-05-05 13:36:31 UTC) #5
stephana-chromium
https://codereview.chromium.org/1085583006/diff/400001/platform_tools/ios/bin/ios_setup.sh File platform_tools/ios/bin/ios_setup.sh (right): https://codereview.chromium.org/1085583006/diff/400001/platform_tools/ios/bin/ios_setup.sh#newcode82 platform_tools/ios/bin/ios_setup.sh:82: # If this is already mounted we unmount it. ...
5 years, 7 months ago (2015-05-05 14:30:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085583006/420001
5 years, 7 months ago (2015-05-05 14:31:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 14:55:11 UTC) #10
Message was sent while issue was closed. 
Committed patchset #22 (id:420001) as
https://skia.googlesource.com/skia/+/deee2980f41cb9586bb7a596cf99d25775f7c698

Powered by Google App Engine
This is Rietveld 408576698