components/nacl/loader/nonsfi/nonsfi_listener.cc - Issue 1085583005: Refactor params of NaClProcessMsg_Start.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 1085583005: Refactor params of NaClProcessMsg_Start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nonsfi/nonsfi_listener.cc

diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc

index 5f212babe28493ceace4e5cca3420c6ea80fc720..5fd3162347876a85807e1da30b5509c29658e6c1 100644

--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc

+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc

@@ -149,7 +149,11 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {

CHECK(!params.enable_debug_stub);

CHECK(params.debug_stub_server_bound_socket.fd == -1);

- CHECK(params.handles.empty());

+ CHECK(params.imc_bootstrap_handle == IPC::InvalidPlatformFileForTransit());

+ CHECK(params.irt_handle == IPC::InvalidPlatformFileForTransit());

+ CHECK(params.mac_shm_fd == IPC::InvalidPlatformFileForTransit());

+ CHECK(params.debug_stub_server_bound_socket ==

+ IPC::InvalidPlatformFileForTransit());

// We are only expecting non-SFI mode to be used with NaCl for now,

// not PNaCl processes.

CHECK(params.process_type == kNativeNaClProcessType);