Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: components/nacl/loader/nonsfi/nonsfi_listener.cc

Issue 1085583005: Refactor params of NaClProcessMsg_Start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/nonsfi/nonsfi_listener.cc
diff --git a/components/nacl/loader/nonsfi/nonsfi_listener.cc b/components/nacl/loader/nonsfi/nonsfi_listener.cc
index 5f212babe28493ceace4e5cca3420c6ea80fc720..43f1e0c4d281c794d77f84ee837f4fff5790567b 100644
--- a/components/nacl/loader/nonsfi/nonsfi_listener.cc
+++ b/components/nacl/loader/nonsfi/nonsfi_listener.cc
@@ -147,9 +147,12 @@ void NonSfiListener::OnStart(const nacl::NaClStartParams& params) {
CHECK(params.version.size() == 0);
// Ensure that a debug stub FD isn't passed through accidentally.
CHECK(!params.enable_debug_stub);
- CHECK(params.debug_stub_server_bound_socket.fd == -1);
+ CHECK(params.imc_bootstrap_handle == IPC::InvalidPlatformFileForTransit());
+ CHECK(params.irt_handle == IPC::InvalidPlatformFileForTransit());
+ CHECK(params.mac_shm_fd == IPC::InvalidPlatformFileForTransit());
+ CHECK(params.debug_stub_server_bound_socket ==
+ IPC::InvalidPlatformFileForTransit());
- CHECK(params.handles.empty());
// We are only expecting non-SFI mode to be used with NaCl for now,
// not PNaCl processes.
CHECK(params.process_type == kNativeNaClProcessType);

Powered by Google App Engine
This is Rietveld 408576698