Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: components/nacl/common/nacl_types.cc

Issue 1085583005: Refactor params of NaClProcessMsg_Start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/common/nacl_types.cc
diff --git a/components/nacl/common/nacl_types.cc b/components/nacl/common/nacl_types.cc
index f7e628b45b5714e601b99f62c1e7d2ad939156ce..44a545da85cbc811296fad5ddce5ff12fa4d3fb0 100644
--- a/components/nacl/common/nacl_types.cc
+++ b/components/nacl/common/nacl_types.cc
@@ -9,6 +9,14 @@ namespace nacl {
NaClStartParams::NaClStartParams()
: nexe_file(IPC::InvalidPlatformFileForTransit()),
+ imc_bootstrap_handle(IPC::InvalidPlatformFileForTransit()),
+ irt_handle(IPC::InvalidPlatformFileForTransit()),
+#if defined(OS_MACOSX)
+ mac_shm_fd(IPC::InvalidPlatformFileForTransit()),
+#endif
+#if defined(OS_POSIX)
+ debug_stub_server_bound_socket(IPC::InvalidPlatformFileForTransit()),
+#endif
validation_cache_enabled(false),
enable_debug_stub(false),
enable_ipc_proxy(false),
@@ -19,18 +27,31 @@ NaClStartParams::NaClStartParams()
NaClStartParams::~NaClStartParams() {
}
-NaClResourceFileInfo::NaClResourceFileInfo()
+NaClResourcePrefetchResult::NaClResourcePrefetchResult()
: file(IPC::InvalidPlatformFileForTransit()) {
}
-NaClResourceFileInfo::NaClResourceFileInfo(
+NaClResourcePrefetchResult::NaClResourcePrefetchResult(
IPC::PlatformFileForTransit file,
const base::FilePath& file_path_metadata,
const std::string& file_key)
: file(file), file_path_metadata(file_path_metadata), file_key(file_key) {
}
-NaClResourceFileInfo::~NaClResourceFileInfo() {
+NaClResourcePrefetchResult::~NaClResourcePrefetchResult() {
+}
+
+NaClResourcePrefetchRequest::NaClResourcePrefetchRequest() {
+}
+
+NaClResourcePrefetchRequest::NaClResourcePrefetchRequest(
+ const std::string& file_key,
+ const std::string& resource_url)
+ : file_key(file_key),
+ resource_url(resource_url) {
+}
+
+NaClResourcePrefetchRequest::~NaClResourcePrefetchRequest() {
}
NaClLaunchParams::NaClLaunchParams()
@@ -48,7 +69,7 @@ NaClLaunchParams::NaClLaunchParams(
uint64_t nexe_token_lo,
uint64_t nexe_token_hi,
const std::vector<
- std::pair<std::string, std::string> >& resource_files_to_prefetch,
+ NaClResourcePrefetchRequest>& resource_prefetch_request_list,
int render_view_id,
uint32 permission_bits,
bool uses_nonsfi_mode,
@@ -57,7 +78,7 @@ NaClLaunchParams::NaClLaunchParams(
nexe_file(nexe_file),
nexe_token_lo(nexe_token_lo),
nexe_token_hi(nexe_token_hi),
- resource_files_to_prefetch(resource_files_to_prefetch),
+ resource_prefetch_request_list(resource_prefetch_request_list),
render_view_id(render_view_id),
permission_bits(permission_bits),
uses_nonsfi_mode(uses_nonsfi_mode),

Powered by Google App Engine
This is Rietveld 408576698