Rename X509Certificate::VerifyFlags to CertVerifier::VerifyFlags

Rename X509Certificate::VerifyFlags to CertVerifier::VerifyFlags

Now that verification happens in CertVerifier::Verify(), the flags
should be moved from X509Certificate into CertVerifier

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152918

[Ryan Sleevi, 2012-08-15 05:57:35]

wtc: Shuffling stamp

[wtc, 2012-08-15 22:44:03]

Patch set 3 LGTM.  I have a question about
cert_verify_proc_openssl.cc.

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
File net/base/cert_verify_proc_openssl.cc (right):

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
net/base/cert_verify_proc_openssl.cc:14: #include "net/base/cert_verifier.h"

This file doesn't seem to need to include this header because
it isn't using CertVerify::VERIFY_xxx.  See my comment about
the "int flags" argument below.

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
net/base/cert_verify_proc_openssl.cc:210: int flags,

I found that this function ignores the |flags| argument.
This seems problematic.

[Ryan Sleevi, 2012-08-15 23:07:05]

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
File net/base/cert_verify_proc_openssl.cc (right):

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
net/base/cert_verify_proc_openssl.cc:14: #include "net/base/cert_verifier.h"
On 2012/08/15 22:44:03, wtc wrote:
> 
> This file doesn't seem to need to include this header because
> it isn't using CertVerify::VERIFY_xxx.  See my comment about
> the "int flags" argument below.

Good catch, removed.

http://codereview.chromium.org/10855168/diff/10001/net/base/cert_verify_proc_...
net/base/cert_verify_proc_openssl.cc:210: int flags,
On 2012/08/15 22:44:03, wtc wrote:
> 
> I found that this function ignores the |flags| argument.
> This seems problematic.

The Android function lacks any ability to convert flags to something the JNI
side can use. Thus it's entirely dependent on the trust manager.

Note that, because of this, we also don't support EV on Android.

[commit-bot: I haz the power, 2012-08-22 23:14:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10855168/14001

[commit-bot: I haz the power, 2012-08-22 23:30:59]

Try job failure for 10855168-14001 (retry) on win_rel for step "runhooks"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-22 23:34:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10855168/20002

[commit-bot: I haz the power, 2012-08-23 02:00:48]

Change committed as 152918