Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1085483002: Revert of Use custom scrollbars for print preview on non-retina mac displays. (Closed)

Created:
5 years, 8 months ago by raymes
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, Sam McNally
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use custom scrollbars for print preview on non-retina mac displays. (patchset #8 id:140001 of https://codereview.chromium.org/1036943004/) Reason for revert: The bug this hack is working around was fixed in http://src.chromium.org/viewvc/blink?view=rev&rev=193593. This hack can now be reverted. Original issue's description: > Use custom scrollbars for print preview on non-retina mac displays. > > This is a hack to workaround a blink bug where overlay scrollbars aren't > rendered correctly in print preview. This bug is being looked at but > until then we use custom scrollbars that imitate mac scrollbars only > in this specific case. > > BUG=466039 > > Committed: https://crrev.com/6826023abd24c8aa8981f4f0fadcf98f0f962bba > Cr-Commit-Position: refs/heads/master@{#322331} BUG=466039 TBR=thestig@chromium.org Committed: https://crrev.com/0c5f11acb945cf2d0b5a82634be29a62c1416f4a Cr-Commit-Position: refs/heads/master@{#324965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/main.js View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 2 chunks +1 line, -5 lines 0 comments Download
D chrome/browser/resources/pdf/scrollbars_mac.css View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
raymes
Created Revert of Use custom scrollbars for print preview on non-retina mac displays.
5 years, 8 months ago (2015-04-13 01:48:38 UTC) #1
Sam McNally
lgtm
5 years, 8 months ago (2015-04-13 01:58:06 UTC) #2
raymes
TBR thestig@ for component_resources.grd
5 years, 8 months ago (2015-04-13 23:09:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085483002/1
5 years, 8 months ago (2015-04-13 23:11:48 UTC) #5
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-13 23:42:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 00:44:56 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 00:46:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c5f11acb945cf2d0b5a82634be29a62c1416f4a
Cr-Commit-Position: refs/heads/master@{#324965}

Powered by Google App Engine
This is Rietveld 408576698