Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 108543004: Fix pkg-config invocation for GN (Closed)

Created:
7 years ago by piman
Modified:
7 years ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix pkg-config invocation for GN We were missing the /usr/lib*/pkgconfig dir in PKG_CONFIG_PATH. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
build/config/linux/pkg-config.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
7 years ago (2013-12-18 01:41:17 UTC) #1
brettw
lgtm
7 years ago (2013-12-18 05:39:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/108543004/1
7 years ago (2013-12-18 05:40:09 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-18 07:32:02 UTC) #4
Message was sent while issue was closed.
Change committed as 241520

Powered by Google App Engine
This is Rietveld 408576698