Source/core/svg/animation/SVGSMILElement.cpp - Issue 108543003: Consistently use AtomicString for namespaceURI / prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 108543003: Consistently use AtomicString for namespaceURI / prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp

index f79ef568573eb80b04096efbbee8c03eae19ce73..7dbc0aedd5b496537235f8ba4d6f8bbac8c6dc63 100644

--- a/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/Source/core/svg/animation/SVGSMILElement.cpp

@@ -252,7 +252,7 @@ static inline QualifiedName constructQualifiedName(const SVGElement* svgElement,

if (!Document::parseQualifiedName(attributeName, prefix, localName, ASSERT_NO_EXCEPTION))

return anyQName();

- String namespaceURI = svgElement->lookupNamespaceURI(prefix);

+ const AtomicString& namespaceURI = svgElement->lookupNamespaceURI(prefix);

if (namespaceURI.isEmpty())

return anyQName();

« Source/core/dom/Node.cpp ('K') | « Source/core/dom/Node.cpp ('k') | Source/core/xml/NativeXPathNSResolver.h » ('j') | no next file with comments »