Source/core/dom/Node.h - Issue 108543003: Consistently use AtomicString for namespaceURI / prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.h

Issue 108543003: Consistently use AtomicString for namespaceURI / prefix (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.h

diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h

index 7ada89d3152291456f7ee852d61418e793937035..d58414731a32437455ee1430aee88753c07b9a1d 100644

--- a/Source/core/dom/Node.h

+++ b/Source/core/dom/Node.h

@@ -210,9 +210,9 @@ public:

bool isSameNode(Node* other) const { return this == other; }

bool isEqualNode(Node*) const;

bool isDefaultNamespace(const AtomicString& namespaceURI) const;

- String lookupPrefix(const AtomicString& namespaceURI) const;

- String lookupNamespaceURI(const String& prefix) const;

- String lookupNamespacePrefix(const AtomicString& namespaceURI, const Element* originalElement) const;

+ const AtomicString& lookupPrefix(const AtomicString& namespaceURI) const;

+ const AtomicString& lookupNamespaceURI(const String& prefix) const;

+ const AtomicString& lookupNamespacePrefix(const AtomicString& namespaceURI, const Element* originalElement) const;

String textContent(bool convertBRsToNewlines = false) const;

void setTextContent(const String&);

« no previous file with comments | « Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp ('k') | Source/core/dom/Node.cpp » ('j') | Source/core/dom/Node.cpp » ('J')